Skip to content

Commit 13d2815

Browse files
committed
Run node tests
Currently we have a job for each supported version of Bitcoin Core and in it we run the integration tests. Note also that `node` is currently not a member of the workspace. So it misses out on all the benefits of `run_task` (e.g., linting). However `node` cannot be directly run using `run_task` because of its unusual features but since we already have the `Integration` job set up to manage these features we can just run the `node` tests from there also. This has the added advantage that the same downloaded Bitcoin Core binary will be used (I hope). Add a script and call it from the `Integration` job. In the script first run the `node` tests and then run the integration tests. Add a script to lint the workspace now that `node` cannot be linted with no features. While we are at it update the justfile now that `node` can be linted and formatted as part of workspace commands.
1 parent 0b00390 commit 13d2815

File tree

7 files changed

+1633
-13
lines changed

7 files changed

+1633
-13
lines changed

.github/workflows/rust.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ jobs:
119119
- name: "Set dependencies"
120120
run: cp Cargo-${{ matrix.dep }}.lock Cargo.lock
121121
- name: "Run test script"
122-
run: ./maintainer-tools/ci/run_task.sh lint
122+
run: contrib/lint.sh
123123

124124
Docs:
125125
name: Docs - stable toolchain
@@ -232,4 +232,4 @@ jobs:
232232
- name: "Select toolchain"
233233
uses: dtolnay/rust-toolchain@stable
234234
- name: "Run integration tests"
235-
run: cd integration_test && cargo test --features=${{ matrix.feature }}
235+
run: ./contrib/version_specific_tests.sh ${{ matrix.feature }}

0 commit comments

Comments
 (0)