Run node tests

Currently we have a job for each supported version of Bitcoin Core and
in it we run the integration tests.

Note also that `node` is currently not a member of the workspace. So it
misses out on all the benefits of `run_task` (e.g., linting).

However `node` cannot be directly run using `run_task` because of its
unusual features but since we already have the `Integration` job set up
to manage these features we can just run the `node` tests from there
also. This has the added advantage that the same downloaded Bitcoin Core
binary will be used (I hope).

Add a script and call it from the `Integration` job. In the script first
run the `node` tests and then run the integration tests.

Author: tcharding

.github/workflows/rust.yaml

@@ -232,4 +232,4 @@ jobs:
       - name: "Select toolchain"
         uses: dtolnay/rust-toolchain@stable
       - name: "Run integration tests"
-        run: cd integration_test && cargo test --features=${{ matrix.feature }}
+        run: ./contrib/version_specific_tests.sh ${{ matrix.feature }}

Cargo.toml

@@ -1,6 +1,6 @@
 [workspace]
-members = ["client", "types", "jsonrpc"]
-exclude = ["integration_test", "node", "verify"]
+members = ["client", "types", "jsonrpc", "node"]
+exclude = ["integration_test", "verify"]
 resolver = "2"
 
 [patch.crates-io.corepc-client]

contrib/version_specific_tests.sh

@@ -0,0 +1,50 @@
+#!/usr/bin/env bash
+#
+# Run Bitcoin Core version specific tests (the `integration_test` and `node` crates.)
+#
+# The `node` crate features are different from a normal crate because:
+#
+# - `node` cannot be built with --no-default-features
+# - `node` expects at least one version feature e.g., --features=28_0
+# - `node` supports downloading the Bitcoin Core binary and also running `bitcoind` from the host.
+#
+# In CI we always want to download the Bitcoin Core binary. This means we always enable `download`.
+# Also, we always enable exactly one feature (even though multiple features will just cause the
+# higher one to override the lower one).
+#
+# These comments apply to the integration test crate also because it depends on `node`.
+
+set -euox pipefail
+
+REPO_DIR=$(git rev-parse --show-toplevel)
+NODE_DIR="$REPO_DIR/node"
+INTEGRATION_TEST_DIR="$REPO_DIR/integration_test"
+
+main() {
+    local version_feature="${1}"
+
+    do_node_tests "$version_feature"
+    do_integration_tests "$version_feature"
+}
+
+do_node_tests() {
+    local version_feature="${1}"
+
+    pushd "$NODE_DIR" > /dev/null
+    cargo test --features=download,"$version_feature"
+    popd > /dev/null
+}
+
+do_integration_tests() {
+    local version_feature="${1}"
+
+    pushd "$NODE_DIR" > /dev/null
+    cargo test --features="$version_feature"
+    popd > /dev/null
+}
+
+#
+# Main script
+#
+main "$@"
+exit 0