Skip to content

Conversation

@leopardracer
Copy link
Contributor

This pull request contains changes to improve clarity, correctness and structure.

Description correction:
Corrected cross compiled to cross-compiled
Corrected integration test to integration tests

Please review the changes and let me know if any additional changes are needed.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7f2674f; successfully ran local tests; sgtm

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7f2674f

@apoelstra apoelstra merged commit 00bd0cd into rust-bitcoin:master Nov 28, 2024
15 checks passed
Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge ACK 7f2674f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants