Merge #19: Add support for corepc

d6bcfac Add support for corepc (Tobin C. Harding)

Pull request description:

  Currently the `corpec` repository excludes the `node` crate because it has unusual feature requirements - it requires at least one version feature.

  Add support for testing `node`. The logic in `build_and_test` is general and uses a new var defined in `contrib/test_vars.sh` but does not require this var to exist.

  The logic in `do_lint` is ugly and specific to `node`. I couldn't think of a cleaner way to do it.

ACKs for top commit:
  apoelstra:
    ACK d6bcfac

Tree-SHA512: f000ff35caa2c69d25d634d9db015cc716f917e417137de4b2034aa9091f33ab166ad448c964e219d3404464394ccfaa4921460b32bf2c86cd106f9c00b029d9

Author: apoelstra

ci/run_task.sh

@@ -132,6 +132,9 @@ build_and_test() {
             verbose_say "FEATURES_WITH_NO_STD: ${FEATURES_WITH_NO_STD}"
             verbose_say "FEATURES_WITHOUT_STD: ${FEATURES_WITHOUT_STD}"
             verbose_say "EXAMPLES: ${EXAMPLES:-}"
+            if [[ -v EXACT_FEATURES && ${#EXACT_FEATURES[@]} -gt 0 ]]; then
+                verbose_say "EXACT_FEATURES: ${EXACT_FEATURES[*]}"
+            fi
         fi
         pushd "$REPO_DIR/$crate" > /dev/null
 
@@ -164,8 +167,14 @@ do_test() {
 # Each crate defines its own feature matrix test so feature combinations
 # can be better controlled.
 do_feature_matrix() {
+    # For crates that have unusual feature requirements (e.g. `corepc`).
+    if [[ -v EXACT_FEATURES && ${#EXACT_FEATURES[@]} -gt 0 ]]; then
+        for features in "${EXACT_FEATURES[@]}"; do
+            $cargo build --no-default-features --features="$features"
+            $cargo test --no-default-features --features="$features"
+        done
     # rust-miniscript only: https://github.com/rust-bitcoin/rust-miniscript/issues/681
-    if [ -n "${FEATURES_WITH_NO_STD}" ]; then
+    elif [ -n "${FEATURES_WITH_NO_STD}" ]; then
         $cargo build --no-default-features --features="no-std"
         $cargo test --no-default-features --features="no-std"
 
@@ -219,10 +228,14 @@ loop_features() {
 do_lint() {
     need_nightly
 
-    # Lint various feature combinations to try and catch mistakes in feature gating.
-    $cargo clippy --workspace --all-targets --keep-going -- -D warnings
     $cargo clippy --workspace --all-targets --all-features --keep-going -- -D warnings
-    $cargo clippy --workspace --all-targets --no-default-features --keep-going -- -D warnings
+
+    # Ugly hack to skip `corpec` because `node` does not build with no default features.
+    if echo "$REPO_DIR" | grep -viq "corepc"; then
+        # Lint various feature combinations to try and catch mistakes in feature gating.
+        $cargo clippy --workspace --all-targets --keep-going -- -D warnings
+        $cargo clippy --workspace --all-targets --no-default-features --keep-going -- -D warnings
+    fi
 }
 
 # We should not have any duplicate dependencies. This catches mistakes made upgrading dependencies
@@ -343,3 +356,4 @@ need_nightly() {
 #
 main "$@"
 exit 0
+