ci: Build and test with all features #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We test various combinations of features in the feature matrix but somehow we forgot to build and test with `--all-features`. We do lint with all features so this is not a massive fail but its a fail none the less. Discovered by Andrew's CI while reviewing recent changes to `corepc`.
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 17, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` has been patched. Additionally we discovered that we were not _testing_ the docs with `--all-features` (or any code for that matter other than linting). Fixed in: rust-bitcoin/rust-bitcoin-maintainer-tools#20 Which this patch uses. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests. In order to get MSRV building we make all deps use `default-features = false` then explicitly enable just what we need. Also change the feature guarding in the build script so that `--all-features` works. This is already supported in the main crate code since the highest version feature overrides the lower ones.
This was referenced Feb 17, 2025
Member
Author
|
Tested in rust-bitcoin/rust-bitcoin#4069 |
Member
|
ACK e5102f4 |
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 18, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` has been patched. Additionally we discovered that we were not _testing_ the docs with `--all-features` (or any code for that matter other than linting). Fixed in: rust-bitcoin/rust-bitcoin-maintainer-tools#20 Which this patch uses. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests. In order to get MSRV building we make all deps use `default-features = false` then explicitly enable just what we need. Also change the feature guarding in the build script so that `--all-features` works. This is already supported in the main crate code since the highest version feature overrides the lower ones.
apoelstra
added a commit
to rust-bitcoin/rust-bitcoin
that referenced
this pull request
Feb 19, 2025
cdece24 Update to latest maintainer-tools (Tobin C. Harding) Pull request description: We have made a couple of improvements to the `run_task` script lately (*cough* actually test code with `--all-features`). Lets update to use it. This PR explicitly tests rust-bitcoin/rust-bitcoin-maintainer-tools#20 because it uses the commit hash created in that PR. ACKs for top commit: apoelstra: ACK cdece24; successfully ran local tests; will one-ack merge this since it is trivial Tree-SHA512: 97597d01beb3b0a87fb0c279ba0e57093f4898a38e7373040cfa18b16c62f9cbceb41ac53429a2e05f70f2ea9fdd7d409e9925131575b3f66d00c5395ba6bfc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test various combinations of features in the feature matrix but somehow we forgot to build and test with
--all-features. We do lint with all features so this is not a massive fail but its a fail none the less.Discovered by Andrew's CI while reviewing recent changes to
corepc.