risc-v: When exceptions are provided in a settings file, code is produced that breaks build without `rt` enabled

[kurtjd]

In my settings file I define some exceptions.

When I generate the pac with this yml, a pub enum Exception is generated and the pac_enum macro wraps it.

However, the macro expanded depends on riscv_rt::TrapFrame so if the rt feature is not enabled, this will not build. I had considered changing the generated code to include #[cfg(feature = "rt")] and fall back on pub use riscv::interrupt::Exception but I don't think is really sound.

Curious if this is expected behavior (making riscv-rt no longer optional) or if any one has other ideas for a change that works in configurations without rt enabled. Thank you!

[burrbull]

@romancardenas look at this, please

[romancardenas]

Will take a look ASAP! Probably the issue is in the riscv::pac_enum macro, which must be tweaked to feature-gate the handler for exceptions if rt is disabled

[kurtjd]

Thanks for looking into it. That makes sense, though wasn't sure what the best approach would be for if rt is disabled.

[romancardenas]

This issue is being solved at rust-embedded/riscv#345 . The svd2rust is not the cause of the error. @burrbull Feel free to close the issue, or, if you prefer, we can leave it open until the fix is merged and released in crates.io