You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: faq.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -78,11 +78,11 @@ Create a separate branch for each task in your private fork. Complete the task i
78
78
79
79
##### <ins>*- When is a task considered completed?*</ins><br/>
80
80
81
-
A task is marked as completed when you've made a Pull Request, and it's been reviewed, approved and merged. After you complete your Pull Request, remove the "NOT READY / DRAFT / WIP" marker from the title and specify [our bot](https://github.com/1tbot) as a reviewer and tag all of your mentors in the comments section. Before mentor can merge your pull request into the main branch, you need to receive approval. If more than one mentor has reviewed your Pull Request and requested changes, you must receive approval from all involved mentors. If all the conditions are executed, mentors will be able to merge your PR and task considered as completed.
81
+
A task is marked as completed when you've made a Pull Request, and it's been reviewed and approved by all your mentors. After you complete your Pull Request, remove the "NOT READY / DRAFT / WIP" marker from the title and specify [our bot](https://github.com/1tbot) as a reviewer and tag all of your mentors in the comments section. Before [our bot](https://github.com/1tbot)can merge your pull request into the main branch, you need to receive approval. Before your pull request can be merged into the main branch, you must receive approval from all of your assigned mentors.
82
82
83
83
##### <ins>*- How do mentors distinguish between finished Pull Requesters and unfinished Pull Requesters?*</ins><br/>
84
84
85
-
A task is marked as completed when you've made a Pull Request, and it's been reviewed and approved by one of the reviewers. After you complete your Pull Request, remove the "NOT READY / DRAFT / WIP" marker from the title and specify [our bot](https://github.com/1tbot) as a reviewer and tag all of your mentors in the comments section.
85
+
A task is marked as completed when you've made a Pull Request, and it's been reviewed and approved by all your mentors. After you complete your Pull Request, remove the "NOT READY / DRAFT / WIP" marker from the title and specify [our bot](https://github.com/1tbot) as a reviewer and tag all of your mentors in the comments section.
86
86
##### <ins>*- Should I open an unfinished PR?*</ins><br/>
87
87
88
88
Yes, you should. Open a PR as soon as you can, marking it with "NOT READY / DRAFT / WIP" in the title . Your mentors will review it once you remove this marker and specify [our bot](https://github.com/1tbot) as a reviewer and tag all of your mentors in the comments section.
@@ -91,9 +91,9 @@ Yes, you should. Open a PR as soon as you can, marking it with "NOT READY / DRAF
91
91
92
92
Please don't do PR merge yourself. Your mentors make the merge themselves.
93
93
94
-
##### <ins>*- How many mentors need to approve before I can merge?*</ins><br/>
94
+
##### <ins>*- How many mentors need to approve before bot can merge?*</ins><br/>
95
95
96
-
You need approval from at least one mentor before merging the Pull Request into the main branch. However, if more than one mentor has reviewed your Pull Request and requested changes, you must receive approval from all of them.
96
+
To improve the quality of reviews and accelerate the exchange of experience, a PR must be approved by all of your mentors. A task will not be considered completed without receiving approval from every assigned mentor.
97
97
98
98
##### <ins>*- Where should I answer the questions in the first chapter?*</ins><br/>
Copy file name to clipboardExpand all lines: orientation.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -174,7 +174,7 @@ This course is continually evolving, and it's important to stay updated with the
174
174
For each task of the rustcamp, you should create and submit a separate [PR (pull request)][PR]. Make sure to give your PR a [relevant title](https://github.com/rust-lang-ua/rustcamp/blob/master/faq.md#--how-should-i-name-pr). After you've completed your pull request, please remove any markers like "NOT READY", "DRAFT", or "WIP" from the title and specify [our bot](https://github.com/1tbot) as a reviewer and tag all of your mentors in the comments section. All communication about PR-s happens via GitHub, so please always use the PR comment section to tag mentors and ask for a review.
175
175
176
176
Please, don't do PR merge yourself.
177
-
Before merging the pull request into the main branch, you need to receive approval from at least one mentor. If more than one mentor has reviewed your Pull Request and requested changes, you must receive approval from all involved mentors. If all the conditions are executed, [our bot](https://github.com/1tbot) will be able to merge your PR.
177
+
To ensure a thorough review and exchange of experience between mentors, your pull request must be approved by **all** of your assigned mentors before it can be merged into the main branch. After receiving approvals from all mentors, [our bot](https://github.com/1tbot) will merge your PR.
178
178
179
179
Each task of the rustcamp is a [Cargo workspace member][workspace], meaning you can run and test it from the project root using commands like `cargo run -p task_1_8`. We highly recommend using tools like [rustfmt] and [Clippy] while writing your [Rust] code.
0 commit comments