Build with -Werror=implicit-function-declaration

XrXr · tgross35 · commit 64282a7c6806 · 2024-10-03T11:24:49.000-04:00
To prevent fail-fast in situations like rust-lang/rust#125619, where an upstream source compiles but creates a link error way downstream.
diff --git a/build.rs b/build.rs
@@ -327,6 +327,8 @@ mod c {
             // in https://github.com/rust-lang/compiler-rt/blob/c8fbcb3/cmake/config-ix.cmake#L19.
             cfg.flag_if_supported("-fomit-frame-pointer");
             cfg.define("VISIBILITY_HIDDEN", None);
+            // Avoid implicitly creating references to undefined functions
+            cfg.flag("-Werror=implicit-function-declaration");
         }
 
         // int_util.c tries to include stdlib.h if `_WIN32` is defined,

Original file line number	Diff line number	Diff line change
`@@ -327,6 +327,8 @@ mod c {`
`327`	`327`	`// in https://github.com/rust-lang/compiler-rt/blob/c8fbcb3/cmake/config-ix.cmake#L19.`
`328`	`328`	`cfg.flag_if_supported("-fomit-frame-pointer");`
`329`	`329`	`cfg.define("VISIBILITY_HIDDEN", None);`
	`330`	`+ // Avoid implicitly creating references to undefined functions`
	`331`	`+ cfg.flag("-Werror=implicit-function-declaration");`
`330`	`332`	`}`
`331`	`333`
`332`	`334`	// int_util.c tries to include stdlib.h if `_WIN32` is defined,