fix: unnecessary_lazy_evaluations suggests wrongly for async closure (#14644)

Closes #14578

changelog: [`unnecessary_lazy_evaluations`] fix wrong suggestions for
async closure

Author: samueltardieu

clippy_lints/src/methods/unnecessary_lazy_eval.rs

@@ -24,7 +24,12 @@ pub(super) fn check<'tcx>(
     let is_bool = cx.typeck_results().expr_ty(recv).is_bool();
 
     if (is_option || is_result || is_bool)
-        && let hir::ExprKind::Closure(&hir::Closure { body, fn_decl, .. }) = arg.kind
+        && let hir::ExprKind::Closure(&hir::Closure {
+            body,
+            fn_decl,
+            kind: hir::ClosureKind::Closure,
+            ..
+        }) = arg.kind
     {
         let body = cx.tcx.hir_body(body);
         let body_expr = &body.value;

tests/ui/unnecessary_lazy_eval.fixed

@@ -321,3 +321,7 @@ fn panicky_arithmetic_ops(x: usize, y: isize) {
     let _x = false.then_some(f1 + f2);
     //~^ unnecessary_lazy_evaluations
 }
+
+fn issue14578() {
+    let _: Box<dyn std::future::Future<Output = i32>> = Box::new(true.then(async || 42).unwrap());
+}

tests/ui/unnecessary_lazy_eval.rs

@@ -321,3 +321,7 @@ fn panicky_arithmetic_ops(x: usize, y: isize) {
     let _x = false.then(|| f1 + f2);
     //~^ unnecessary_lazy_evaluations
 }
+
+fn issue14578() {
+    let _: Box<dyn std::future::Future<Output = i32>> = Box::new(true.then(async || 42).unwrap());
+}