style: use zip-the-function all over the place

makes the code a bit more concise by removing the need for explicit
`.iter()`

Author: ada4a

clippy_utils/src/lib.rs

@@ -84,7 +84,7 @@ pub use self::hir_utils::{
 use core::mem;
 use core::ops::ControlFlow;
 use std::collections::hash_map::Entry;
-use std::iter::{once, repeat_n};
+use std::iter::{once, repeat_n, zip};
 use std::sync::{Mutex, MutexGuard, OnceLock};
 
 use itertools::Itertools;
@@ -582,7 +582,7 @@ pub fn can_mut_borrow_both(cx: &LateContext<'_>, e1: &Expr<'_>, e2: &Expr<'_>) -
         return false;
     }
 
-    for (x1, x2) in s1.iter().zip(s2.iter()) {
+    for (x1, x2) in zip(&s1, &s2) {
         if expr_custom_deref_adjustment(cx, x1).is_some() || expr_custom_deref_adjustment(cx, x2).is_some() {
             return false;
         }
@@ -1975,26 +1975,20 @@ pub fn is_expr_identity_of_pat(cx: &LateContext<'_>, pat: &Pat<'_>, expr: &Expr<
         (PatKind::Tuple(pats, dotdot), ExprKind::Tup(tup))
             if dotdot.as_opt_usize().is_none() && pats.len() == tup.len() =>
         {
-            pats.iter()
-                .zip(tup)
-                .all(|(pat, expr)| is_expr_identity_of_pat(cx, pat, expr, by_hir))
+            zip(pats, tup).all(|(pat, expr)| is_expr_identity_of_pat(cx, pat, expr, by_hir))
         },
         (PatKind::Slice(before, slice, after), ExprKind::Array(arr))
             if slice.is_none() && before.len() + after.len() == arr.len() =>
         {
-            (before.iter().chain(after))
-                .zip(arr)
-                .all(|(pat, expr)| is_expr_identity_of_pat(cx, pat, expr, by_hir))
+            zip(before.iter().chain(after), arr).all(|(pat, expr)| is_expr_identity_of_pat(cx, pat, expr, by_hir))
         },
         (PatKind::TupleStruct(pat_ident, field_pats, dotdot), ExprKind::Call(ident, fields))
             if dotdot.as_opt_usize().is_none()
                 && let ExprKind::Path(ident) = ident.kind =>
         {
             field_pats.len() == fields.len()
                 && qpath_res(&pat_ident, pat.hir_id) == qpath_res(&ident, expr.hir_id)
-                && (field_pats.iter())
-                    .zip(fields)
-                    .all(|(pat, expr)| is_expr_identity_of_pat(cx, pat, expr, by_hir))
+                && zip(field_pats, fields).all(|(pat, expr)| is_expr_identity_of_pat(cx, pat, expr, by_hir))
         },
         (PatKind::Struct(pat_ident, field_pats, false), ExprKind::Struct(ident, fields, hir::StructTailExpr::None)) => {
             field_pats.len() == fields.len()