Skip to content

fix(match_like_matches_macro): FP with guards containing if let #15876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(match_like_matches_macro): FP with guards containing if let #15876

wants to merge 2 commits into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 13, 2025 •
edited
Loading

Fixes #15841

changelog: [match_like_matches_macro]: FP with guards containing if let

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
Copy link
Contributor Author

ada4a commented Oct 13, 2025

Depends on #15854, so @rustbot blocked

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 13, 2025
@ada4a ada4a changed the title fix(match_like_matches_macro): FP on guards containing if let fix(match_like_matches_macro): FP with guards containing if let Oct 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

Lintcheck changes for 7b83f42

Lint Added Removed Changed
clippy::match_like_matches_macro 0 0 58

This comment will be updated if you push new changes

@ada4a ada4a force-pushed the 15841-match_like_matches branch from 08fd51e to 71c6ad5 Compare October 16, 2025 19:58
@ada4a
Copy link
Contributor Author

ada4a commented Oct 16, 2025

PR merged, so @rustbot ready

@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Oct 16, 2025
Alexendoo
Alexendoo reviewed Oct 19, 2025
View reviewed changes
clippy_lints/src/matches/match_like_matches.rs Outdated
|diag| {
diag.span_suggestion_verbose(
e.span,
"try",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're issuing a verbose suggestion now we'd want to ditch the short try message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there that much to add to the suggestion though? I think any longer message would need to mention matches! (e.g. "use matches! directly"), but that's already a part of the diagnostic message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of repetition is fine, it's nice to spell out the suggestion when we have the room

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:)

@ada4a ada4a force-pushed the 15841-match_like_matches branch from 71c6ad5 to 6197d61 Compare October 20, 2025 14:19
@ada4a ada4a force-pushed the 15841-match_like_matches branch from 6197d61 to 7b83f42 Compare October 20, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexendoo Alexendoo Alexendoo left review comments

Assignees

@Alexendoo Alexendoo

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

match-like-matches-macro does not like if_let_guards

3 participants

@ada4a @rustbot @Alexendoo