Skip to content

Commit c9e6159

Browse files
committed
Undo allowing reloading of killed sessions.
Will possibly work on this in the future.
1 parent 346da4f commit c9e6159

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

InterSpec/InterSpecServer.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,10 @@ namespace InterSpecServer
197197
If session token does not already exist, it will not be added.
198198
199199
Returns true if successful (found session token, and reset state).
200+
201+
Currently commented out because it is unused.
200202
*/
201-
InterSpec_API bool set_session_reload_allow( const char *session_token );
203+
//InterSpec_API bool set_session_reload_allow( const char *session_token );
202204

203205
#if( !BUILD_FOR_WEB_DEPLOYMENT )
204206
/** Open one or more files from the filesystem. For macOS this would be

src/InterSpecApp.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1337,9 +1337,9 @@ void InterSpecApp::handleJavaScriptError( const std::string &errorText )
13371337
WApplication::handleJavaScriptError( errorText );
13381338

13391339
#if( !BUILD_FOR_WEB_DEPLOYMENT )
1340-
// Allow re-loading of the window
1341-
if( !m_externalToken.empty() )
1342-
InterSpecServer::set_session_reload_allow( m_externalToken.c_str() );
1340+
// TODO: Allow re-loading of the window - would require implementing each target (exWindow, Electron, etc), and improving error messaging
1341+
//if( !m_externalToken.empty() )
1342+
// InterSpecServer::set_session_reload_allow( m_externalToken.c_str() );
13431343
#endif //#if( !BUILD_FOR_WEB_DEPLOYMENT )
13441344
}//void handleJavaScriptError( const std::string &errorText )
13451345
#endif //#if( WT_VERSION>=0x3030400 )

src/InterSpecServer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ void killServer()
762762
}
763763
}//void set_session_destructing( const char *session_token )
764764

765-
765+
/*
766766
bool set_session_reload_allow( const char *session_token )
767767
{
768768
lock_guard<mutex> lock( ns_sessions_mutex );
@@ -776,7 +776,7 @@ void killServer()
776776
777777
return true;
778778
}//bool set_session_reload_allow( const char *session_token )
779-
779+
*/
780780

781781
int session_status( const char *session_token )
782782
{

0 commit comments

Comments
 (0)