-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Labels
clean-upTidy up code, fix non-breaking problemsTidy up code, fix non-breaking problemsdocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
(this is inspired by questions raised by @rebeccamccabe in #311)
capytaine
usesrad/s
,wavespectra
usesHz
- our internally stated logic (not stated in documentation at all) is to use
rad/s
internally for calculations, but have the user interface beHz
- the code is (mostly) consistent about using
Hz
for frequency inputsfrom_impedance
actually usesHz
for the freq. input (contrary to some of the statements above) - perhaps you were confused by the usage of ω in the docstrings? - this is definitely not great and we should probably switch these usages of ω to ffrom_bem
actually does userad/s
, because this is whatcapytaine
produces - note however, that since we are usually recommending/illustrating uses ourrun_bem
function that swaps the phase angle convention it would probably be most consistent to haverun_bem
also swap toHz
(note that this could be taken care of if we were to complete this issue in
capytaine
: Add frequency (Hz) coordinate to datasets capytaine/capytaine#456)
Metadata
Metadata
Assignees
Labels
clean-upTidy up code, fix non-breaking problemsTidy up code, fix non-breaking problemsdocumentationImprovements or additions to documentationImprovements or additions to documentation