Fix an additional warning that shows up with the latest clang.

Author: insertinterestingnamehere

test/basics/read.c

@@ -6,12 +6,13 @@
 #include <unistd.h>
 
 char const cfilename[] = "test_qthread_read.XXXXXXXXXXXXX";
+#define BUFFER_SIZE 32u // strlen(cfilename) + 1
 
 static aligned_t reader(void *arg) {
   int ret;
-  char buf[strlen(cfilename) + 1];
+  char buf[BUFFER_SIZE];
 
-  memset(buf, 0, strlen(cfilename) + 1);
+  memset(buf, 0, BUFFER_SIZE);
   iprintf("in reader function\n");
   ret = read((int)(intptr_t)arg, buf, 5);
   iprintf("read '%s'\n", buf);
@@ -29,12 +30,12 @@ static aligned_t reader(void *arg) {
 int main(int argc, char *argv[]) {
   aligned_t t;
   int fd;
-  char filename[strlen(cfilename) + 1];
+  char filename[BUFFER_SIZE];
   ssize_t ret;
 
   CHECK_VERBOSE();
 
-  snprintf(filename, strlen(cfilename) + 1, "%s", cfilename);
+  snprintf(filename, BUFFER_SIZE, "%s", cfilename);
   iprintf("filename = '%s'\n", filename);
 
   /* First, set up a temporary file */
@@ -44,8 +45,8 @@ int main(int argc, char *argv[]) {
   if (fd < 0) { perror("mkstemp failed"); }
   assert(fd >= 0);
 
-  ret = write(fd, cfilename, strlen(cfilename));
-  assert(ret == strlen(cfilename));
+  ret = write(fd, cfilename, BUFFER_SIZE - 1u);
+  assert(ret == BUFFER_SIZE - 1u);
 
   ret = (ssize_t)lseek(fd, 0, SEEK_SET);
   assert(ret == 0);