Skip to content

Conversation

@judofyr
Copy link
Contributor

@judofyr judofyr commented Nov 24, 2025

Description

I believe these were leftover from a refactoring by @dcilke related to how we deal with validations in the schema package.

What to review

N/A.

Testing

N/A.

Notes for release

N/A.

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
page-building-studio Ready Ready Preview Comment Nov 28, 2025 10:00am
test-studio Ready Ready Preview Comment Nov 28, 2025 10:00am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio-workshop Ignored Ignored Preview Nov 28, 2025 10:00am
test-next-studio Ignored Ignored Nov 28, 2025 10:00am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-es562837l.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-es562837l.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-11239-chromium-19760275824 || pr-11239-firefox-19760275824 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-11239-chromium-19760275824
  SANITY_E2E_DATASET_FIREFOX=pr-11239-firefox-19760275824

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

⚡️ Editor Performance Report

Deploying studio and running performance tests…

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 44.65% 63687 / 142611
🔵 Statements 44.65% 63687 / 142611
🔵 Functions 48.26% 3401 / 7046
🔵 Branches 79.32% 12913 / 16278
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/@sanity/schema/src/descriptors/convert.ts 92.92% 88.6% 96.15% 92.92% 304-305, 397-398, 406-414, 434-435, 448-455, 511-512, 526-527, 545, 555, 565, 573, 585, 599, 607, 617, 623, 625, 651-652
packages/sanity/src/core/schema/descriptors.ts 100% 100% 100% 100%
Generated in workflow #46581 for commit 0bf3afd by the Vitest Coverage Report Action

@judofyr judofyr force-pushed the cldx-4335/remove-unused-options branch from c4a1c9c to 2c9fbd7 Compare November 25, 2025 09:29
@judofyr judofyr force-pushed the cldx-4353/cache-schema-compiler branch from 6c30f2b to 313f899 Compare November 25, 2025 09:29
@judofyr judofyr self-assigned this Nov 25, 2025
@judofyr judofyr requested a review from dcilke November 25, 2025 09:40
@judofyr judofyr marked this pull request as ready for review November 25, 2025 09:40
@judofyr judofyr requested a review from a team as a code owner November 25, 2025 09:40
@judofyr judofyr requested review from bjoerge and removed request for a team November 25, 2025 09:40
dcilke
dcilke previously approved these changes Nov 25, 2025
bjoerge
bjoerge previously approved these changes Nov 25, 2025
Copy link
Contributor Author

judofyr commented Nov 28, 2025

Merge activity

@judofyr judofyr changed the base branch from cldx-4353/cache-schema-compiler to graphite-base/11239 November 28, 2025 09:23
@judofyr judofyr force-pushed the graphite-base/11239 branch from eb204e5 to 8efdc2b Compare November 28, 2025 09:54
@judofyr judofyr force-pushed the cldx-4335/remove-unused-options branch from 171f61d to 0849e81 Compare November 28, 2025 09:54
@graphite-app graphite-app bot changed the base branch from graphite-base/11239 to main November 28, 2025 09:55
@graphite-app graphite-app bot dismissed stale reviews from bjoerge and dcilke November 28, 2025 09:55

The base branch was changed.

These are no longer required due to some refactorings we did with
validations.
@judofyr
Copy link
Contributor Author

judofyr commented Nov 28, 2025

Re-requesting review due to rebase. There shouldn't be any code changes (but do I have a look in case of a bad rebase)

@judofyr judofyr merged commit eee6ece into main Nov 28, 2025
63 of 64 checks passed
@judofyr judofyr deleted the cldx-4335/remove-unused-options branch November 28, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants