Skip to content

chore(core): improve release status message for the Published status #11293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

chore(core): improve release status message for the Published status #11293

merged 1 commit into from
Nov 28, 2025

Conversation

@pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Nov 27, 2025

Description

Updates the Published Status message to:

This release is published successfully.
It will be available for 365 days, then automatically removed on [specific date]. [Learn about retention].

It fixes this for both, published and archived releases.
Screenshot 2025-11-27 at 11 36 23

Screenshot 2025-11-27 at 11 33 08

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner November 27, 2025 10:36
@pedrobonamin pedrobonamin requested review from stipsan and removed request for a team November 27, 2025 10:36
@vercel
Copy link

vercel bot commented Nov 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
page-building-studio Ready Ready Preview Comment Nov 28, 2025 10:47am
test-studio Ready Ready Preview Comment Nov 28, 2025 10:47am
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
e2e-studio Ignored Ignored Nov 28, 2025 10:47am
studio-workshop Ignored Ignored Preview Nov 28, 2025 10:47am
test-next-studio Ignored Ignored Nov 28, 2025 10:47am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-bhpeyawbw.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-bhpeyawbw.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-11293-chromium-19761426208 || pr-11293-firefox-19761426208 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-11293-chromium-19761426208
  SANITY_E2E_DATASET_FIREFOX=pr-11293-firefox-19761426208

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading

⚡️ Editor Performance Report

Deploying studio and running performance tests…

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 44.75% 63905 / 142791
🔵 Statements 44.75% 63905 / 142791
🔵 Functions 48.37% 3415 / 7060
🔵 Branches 79.36% 12985 / 16361
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/i18n/resources.ts 100% 100% 100% 100%
packages/sanity/src/core/releases/tool/detail/ArchivedReleaseBanner.tsx 100% 50% 100% 100%
packages/sanity/src/core/releases/tool/detail/ReleaseDashboardDetails.tsx 90.62% 74.41% 66.66% 90.62% 66-69, 86-90, 103-104, 112, 127-128, 155-156
packages/sanity/src/core/releases/tool/detail/ReleaseDateInput.tsx 75.86% 100% 50% 75.86% 25-33
Generated in workflow #46608 for commit 58b93ad by the Vitest Coverage Report Action

stipsan
stipsan previously approved these changes Nov 27, 2025
View reviewed changes
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pedrobonamin pedrobonamin enabled auto-merge (squash) November 27, 2025 13:26
pedrobonamin
pedrobonamin commented Nov 28, 2025
View reviewed changes
packages/sanity/src/core/releases/tool/detail/ArchivedReleaseBanner.tsx
}, [retentionDays, release, utcToCurrentZoneDate])

return (
<Card padding={4} radius={4} tone="primary" data-testid="retention-policy-card">
Copy link
Contributor Author

@pedrobonamin pedrobonamin Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from here

This component needs retention days and does some date calculations that we can save by moving it to a new component.
For the case of "active" releases we don't need to render this component, neither use the hooks that are part of it.

Copy link
Member

@stipsan stipsan Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice improvement, best way to improve perf is to split into smaller components like this ✨

@pedrobonamin pedrobonamin requested a review from stipsan November 28, 2025 11:03
@pedrobonamin pedrobonamin merged commit 173fe64 into main Nov 28, 2025
65 of 68 checks passed
@pedrobonamin pedrobonamin deleted the sapp-3271 branch November 28, 2025 13:05
@squiggler squiggler bot mentioned this pull request Nov 28, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stipsan stipsan stipsan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pedrobonamin @stipsan