Skip to content

Commit ff6363c

Browse files
committed
small updates
1 parent 2945fe9 commit ff6363c

File tree

5 files changed

+29
-29
lines changed

5 files changed

+29
-29
lines changed

src/Blake2.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Blake2.Bench", "..\tests\Bl
77
EndProject
88
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Blake2.Test", "..\tests\Blake2.Test\Blake2.Test.csproj", "{791618B6-C4AC-4859-8259-589416D0864A}"
99
EndProject
10-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Blake2Fast", "Blake2Fast\Blake2Fast.csproj", "{D9ABAAEA-7766-497A-88F5-92FF501B51EC}"
10+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Blake2Fast", "Blake2Fast\Blake2Fast.csproj", "{D9ABAAEA-7766-497A-88F5-92FF501B51EC}"
1111
EndProject
1212
Global
1313
GlobalSection(SolutionConfigurationPlatforms) = preSolution

src/Blake2Fast/Blake2Fast.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<VersionPrefix>0.3.0</VersionPrefix>
5-
<TargetFrameworks>netstandard1.1;netstandard1.3;netcoreapp2.1;netcoreapp3.0;net45</TargetFrameworks>
5+
<TargetFrameworks>netstandard1.1;netstandard1.3;netstandard2.0;netcoreapp2.1;netcoreapp3.0;net45</TargetFrameworks>
66
</PropertyGroup>
77

88
<PropertyGroup>
@@ -17,10 +17,10 @@
1717
</ItemGroup>
1818

1919
<ItemGroup Condition="!$(DefineConstants.Contains('FAST_SPAN'))">
20-
<PackageReference Include="System.Memory" Version="4.5.2" />
20+
<PackageReference Include="System.Memory" Version="4.5.3" />
2121
</ItemGroup>
2222

23-
<ItemGroup>
23+
<ItemGroup Condition="'$(TargetFramework)'!='netcoreapp3.0'">
2424
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.5.2" />
2525
</ItemGroup>
2626

src/Blake2Fast/HashAlgorithm.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ internal sealed class Blake2HMAC : HMAC
1717
public sealed override int HashSize => HashSizeValue;
1818
#endif
1919

20-
private Blake2Algorithm alg;
20+
private readonly Blake2Algorithm alg;
2121
private IBlake2Incremental impl;
2222

2323
public Blake2HMAC(Blake2Algorithm hashAlg, int hashBytes, ReadOnlySpan<byte> key)

src/Directory.Build.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<PackageProjectUrl>$(RepositoryUrl)</PackageProjectUrl>
99
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1010
<Copyright>Copyright © 2018-$([System.DateTime]::Today.Year) $(Authors)</Copyright>
11+
<Title>High-Performance BLAKE2 Hashing for .NET</Title>
1112
<Description>High-Performance BLAKE2 Hashing for .NET</Description>
1213
<PackageReleaseNotes>See $(RepositoryUrl)/releases for release-specific notes.</PackageReleaseNotes>
1314

@@ -41,7 +42,7 @@
4142
</PropertyGroup>
4243

4344
<ItemGroup Condition="'$(Configuration)'=='Release'">
44-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" PrivateAssets="all"/>
45+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-19367-01" PrivateAssets="all"/>
4546
</ItemGroup>
4647

4748
</Project>

tests/Blake2.Test/RfcSelfTest.cs

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@
44
using Xunit;
55
using SauceControl.Blake2Fast;
66

7-
internal static class ArrayExtension
8-
{
9-
public static ArraySegment<T> Slice<T>(this T[] a, int start, int count) => new ArraySegment<T>(a, start, count);
10-
}
11-
127
public class RfcSelfTest
138
{
149
private static readonly byte[] blake2bCheck = new byte[] {
@@ -128,26 +123,28 @@ private static bool blake2bHmacSelfTest()
128123

129124
foreach (int diglen in new[] { 20, 32, 48, 64 })
130125
{
131-
var halg = Blake2b.CreateHashAlgorithm(diglen);
132-
var hmac = Blake2b.CreateHMAC(diglen, getTestSequence(diglen));
133-
134-
foreach (int msglen in new[] { 0, 3, 128, 129, 255, 1024 })
126+
using (var halg = Blake2b.CreateHashAlgorithm(diglen))
127+
using (var hmac = Blake2b.CreateHMAC(diglen, getTestSequence(diglen)))
135128
{
136-
var msg = getTestSequence(msglen);
129+
foreach (int msglen in new[] { 0, 3, 128, 129, 255, 1024 })
130+
{
131+
var msg = getTestSequence(msglen);
137132

138133
#if ICRYPTOTRANSFORM
139-
inc.TransformBlock(halg.ComputeHash(msg), 0, diglen, null, 0);
140-
inc.TransformBlock(hmac.ComputeHash(msg), 0, diglen, null, 0);
134+
inc.TransformBlock(halg.ComputeHash(msg), 0, diglen, null, 0);
135+
inc.TransformBlock(hmac.ComputeHash(msg), 0, diglen, null, 0);
141136
#else
142-
inc.Update(halg.ComputeHash(msg));
143-
inc.Update(hmac.ComputeHash(msg));
137+
inc.Update(halg.ComputeHash(msg));
138+
inc.Update(hmac.ComputeHash(msg));
144139
#endif
140+
}
145141
}
146142
}
147143

148144
#if ICRYPTOTRANSFORM
149145
inc.TransformFinalBlock(Array.Empty<byte>(), 0, 0);
150146
var hash = inc.Hash;
147+
inc.Dispose();
151148
#else
152149
var hash = inc.Finish();
153150
#endif
@@ -165,26 +162,28 @@ private static bool blake2sHmacSelfTest()
165162

166163
foreach (int diglen in new[] { 16, 20, 28, 32 })
167164
{
168-
var halg = Blake2s.CreateHashAlgorithm(diglen);
169-
var hmac = Blake2s.CreateHMAC(diglen, getTestSequence(diglen));
170-
171-
foreach (int msglen in new[] { 0, 3, 64, 65, 255, 1024 })
165+
using (var halg = Blake2s.CreateHashAlgorithm(diglen))
166+
using (var hmac = Blake2s.CreateHMAC(diglen, getTestSequence(diglen)))
172167
{
173-
var msg = getTestSequence(msglen);
168+
foreach (int msglen in new[] { 0, 3, 64, 65, 255, 1024 })
169+
{
170+
var msg = getTestSequence(msglen);
174171

175172
#if ICRYPTOTRANSFORM
176-
inc.TransformBlock(halg.ComputeHash(msg), 0, diglen, null, 0);
177-
inc.TransformBlock(hmac.ComputeHash(msg), 0, diglen, null, 0);
173+
inc.TransformBlock(halg.ComputeHash(msg), 0, diglen, null, 0);
174+
inc.TransformBlock(hmac.ComputeHash(msg), 0, diglen, null, 0);
178175
#else
179-
inc.Update(halg.ComputeHash(msg));
180-
inc.Update(hmac.ComputeHash(msg));
176+
inc.Update(halg.ComputeHash(msg));
177+
inc.Update(hmac.ComputeHash(msg));
181178
#endif
179+
}
182180
}
183181
}
184182

185183
#if ICRYPTOTRANSFORM
186184
inc.TransformFinalBlock(Array.Empty<byte>(), 0, 0);
187185
var hash = inc.Hash;
186+
inc.Dispose();
188187
#else
189188
var hash = inc.Finish();
190189
#endif

0 commit comments

Comments
 (0)