Skip to content

Commit 9f0a99e

Browse files
committed
Trying some things for codecov
1 parent 64438a9 commit 9f0a99e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/skmatter/decomposition/_kpcov.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ def _get_kernel(self, X, Y=None):
7777
@abstractmethod
7878
def fit(self, X, Y):
7979
"""Fit the model with X and Y. Subclasses should implement this method."""
80-
pass
8180

8281
def _set_fit_params(self, X):
8382
"""Initializes common fit parameters for PCovR and PCovC."""

src/skmatter/decomposition/_pcov.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ def __init__(
5151
@abstractmethod
5252
def fit(self, X, Y):
5353
"""Fit the model with X and Y. Subclasses should implement this method."""
54-
pass
5554

5655
def _set_fit_params(self, X):
5756
"""Initializes common fit parameters for PCovR and PCovC."""

tests/test_pcovc.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,13 @@ def __init__(self, *args, **kwargs):
2525
)
2626

2727
self.error_tol = 1e-5
28-
2928
self.X, self.Y = get_dataset(return_X_y=True)
3029

30+
# n_samples > 500 to ensure our svd_solver tests catch all cases
31+
X_stacked = np.tile(self.X, (4, 1))
32+
Y_stacked = np.tile(self.Y, 4)
33+
self.X, self.Y = X_stacked, Y_stacked
34+
3135
scaler = StandardScaler()
3236
self.X = scaler.fit_transform(self.X)
3337

@@ -175,8 +179,7 @@ def test_select_sample_space(self):
175179
Check that PCovC implements the sample space version
176180
when :math:`n_{features} > n_{samples}``.
177181
"""
178-
pcovc = self.model(n_components=2, tol=1e-12)
179-
182+
pcovc = self.model(n_components=1, tol=1e-12, svd_solver="arpack")
180183
n_samples = 2
181184

182185
# select range where there are at least 2 classes in Y

0 commit comments

Comments
 (0)