Best way to do Or queries ?

[ajmyers01]

I want to pull back all tImeEntry records that have a type of 1 or 2. how would i go about constructing that using an add_condition block ?

query = AutotaskAPI::QueryXML.new do |query|
query.entity = 'timeentry'
end

year_ago = (DateTime.now - 1.year).to_formatted_s(:iso8601)                                                                                             
query.add_condition('ticketid', 'equals', ticket_id)                                                                                                        

query.add_condition('type', 'equals', 2)  || query.add_condition('type', 'equals', 1) 

[scoop]

I'm afraid this will need an extension of the AutotaskAPI::QueryXML class. An example from the Autotask API docs:

<query>
  <condition>
    <field>firstname
      <expression op="equals">Joe</expression>
    </field>
  </condition>
  <condition operator="OR">
    <field>lastname
      <expression op="equals">Brown</expression>
    </field>
  </condition>
</query>

Basically what's missing is the addition of the operator attribute to the generated XML. I don't have any immediate plans to add this as my time right now is fairly limited.

[ajmyers01]

Okay I'll clean the data after I retrieve it all.

I'll try to find some time to look into the queryxml method more in depth and see if i can propose a solution.

Thanks @scoop

[kbni]

I'm not a ruby developer, but I previously hacked something together for more complex queries (perhaps some of it might be of use?):
https://github.com/kbni/autotask_api/blob/master/lib/autotask_api/query_builder.rb

[trepidity]

Interesting how you added the method_missing. That's something that has been biting me hard on the current API.