fix

Author: lahma

Jint.Tests.Test262/test/skipped.json

@@ -300,6 +300,10 @@
 
   // Esprima problems
 
+  {
+    "source": "built-ins/GeneratorFunction/instance-yield-expr-in-param.js",
+    "reason": "Esprima doesn't detect invalid yield param"
+  },
   {
     "source": "language/expressions/object/method-definition/name-super-prop-param.js",
     "reason": "Esprima problem"

Jint/EsprimaExtensions.cs

@@ -222,14 +222,6 @@ internal static void GetBoundNames(this Node? parameter, List<string> target)
                 else if (parameter is AssignmentPattern assignmentPattern)
                 {
                     parameter = assignmentPattern.Left;
-                    if (assignmentPattern.Right is ClassExpression classExpression)
-                    {
-                        // TODO check if there's more generic rule
-                        if (classExpression.Id is not null)
-                        {
-                            target.Add(classExpression.Id.Name!);
-                        }
-                    }
                     continue;
                 }
                 break;

Jint/Native/Generator/GeneratorInstance.cs

@@ -101,8 +101,7 @@ private JsValue ResumeExecution(ExecutionContext genContext, EvaluationContext c
             }
             else if (result.Type == CompletionType.Return)
             {
-                var value = result.Value.IsUndefined() ? context.ResumedCompletion.GetValueOrDefault() : result.Value;
-                resultValue = new IteratorInstance.ValueIteratorPosition(_engine, value, false);
+                resultValue = new IteratorInstance.ValueIteratorPosition(_engine, result.Value, false);
                 if (_generatorBody.Completed)
                 {
                     _generatorState = GeneratorState.Completed;

Jint/Runtime/Interpreter/Expressions/BindingPatternAssignmentExpression.cs

@@ -48,16 +48,16 @@ internal static Completion ProcessPatterns(
             BindingPattern pattern,
             JsValue argument,
             EnvironmentRecord environment,
-            bool checkObjectPatternPropertyReference = true)
+            bool checkPatternPropertyReference = true)
         {
             if (pattern is ArrayPattern ap)
             {
-                return HandleArrayPattern(context, ap, argument, environment);
+                return HandleArrayPattern(context, ap, argument, environment, checkPatternPropertyReference);
             }
 
             if (pattern is ObjectPattern op)
             {
-                return HandleObjectPattern(context, op, argument, environment, checkObjectPatternPropertyReference);
+                return HandleObjectPattern(context, op, argument, environment, checkPatternPropertyReference);
             }
 
             ExceptionHelper.ThrowArgumentException("Not a pattern");
@@ -83,7 +83,8 @@ private static Completion HandleArrayPattern(
             EvaluationContext context,
             ArrayPattern pattern,
             JsValue argument,
-            EnvironmentRecord environment)
+            EnvironmentRecord environment,
+            bool checkReference)
         {
             var engine = context.Engine;
             var realm = engine.Realm;
@@ -141,7 +142,7 @@ private static Completion HandleArrayPattern(
                             ConsumeFromIterator(iterator, out value, out done);
                         }
 
-                        AssignToIdentifier(engine, identifier.Name, value, environment);
+                        AssignToIdentifier(engine, identifier.Name, value, environment, checkReference);
                     }
                     else if (left is MemberExpression me)
                     {
@@ -215,7 +216,7 @@ private static Completion HandleArrayPattern(
 
                         if (restElement.Argument is Identifier leftIdentifier)
                         {
-                            AssignToIdentifier(engine, leftIdentifier.Name, array, environment);
+                            AssignToIdentifier(engine, leftIdentifier.Name, array, environment, checkReference);
                         }
                         else if (restElement.Argument is BindingPattern bp)
                         {
@@ -256,7 +257,7 @@ private static Completion HandleArrayPattern(
                                 ((FunctionInstance) value).SetFunctionName(new JsString(leftIdentifier.Name));
                             }
 
-                            AssignToIdentifier(engine, leftIdentifier.Name, value, environment);
+                            AssignToIdentifier(engine, leftIdentifier.Name, value, environment, checkReference);
                         }
                         else if (assignmentPattern.Left is BindingPattern bp)
                         {
@@ -350,7 +351,7 @@ private static Completion HandleObjectPattern(
                             ((FunctionInstance) value).SetFunctionName(target.Name);
                         }
 
-                        AssignToIdentifier(context.Engine, target.Name, value, environment);
+                        AssignToIdentifier(context.Engine, target.Name, value, environment, checkReference);
                     }
                     else if (p.Value is BindingPattern bindingPattern)
                     {
@@ -379,7 +380,7 @@ private static Completion HandleObjectPattern(
                         var count = Math.Max(0, source.Properties?.Count ?? 0) - processedProperties.Count;
                         var rest = context.Engine.Realm.Intrinsics.Object.Construct(count);
                         source.CopyDataProperties(rest, processedProperties);
-                        AssignToIdentifier(context.Engine, leftIdentifier.Name, rest, environment);
+                        AssignToIdentifier(context.Engine, leftIdentifier.Name, rest, environment, checkReference);
                     }
                     else if (restElement.Argument is BindingPattern bp)
                     {
@@ -447,7 +448,7 @@ private static void AssignToIdentifier(
             {
                 if (checkReference && lhs.IsUnresolvableReference() && StrictModeScope.IsStrictModeCode)
                 {
-                    ExceptionHelper.ThrowReferenceError(engine.Realm, "invalid reference");
+                    ExceptionHelper.ThrowReferenceError(engine.Realm, lhs);
                 }
                 engine.PutValue(lhs, rval);
             }

Jint/Runtime/Interpreter/Statements/JintForInForOfStatement.cs

@@ -231,7 +231,7 @@ private Completion BodyEvaluation(
                             _assignmentPattern,
                             nextValue,
                             iterationEnv,
-                            checkObjectPatternPropertyReference: _lhsKind != LhsKind.VarBinding);
+                            checkPatternPropertyReference: _lhsKind != LhsKind.VarBinding);
 
                         if (lhsKind == LhsKind.Assignment)
                         {

Jint/Runtime/Interpreter/Statements/JintVariableDeclaration.cs

@@ -100,7 +100,7 @@ protected override Completion ExecuteInternal(EvaluationContext context)
                             declaration.LeftPattern,
                             completion.Value,
                             environment,
-                            checkObjectPatternPropertyReference: _statement.Kind != VariableDeclarationKind.Var);
+                            checkPatternPropertyReference: _statement.Kind != VariableDeclarationKind.Var);
                     }
                     else if (declaration.LeftIdentifierExpression == null
                              || JintAssignmentExpression.SimpleAssignmentExpression.AssignToIdentifier(