Quote foreign key constraint names to support numeric table prefixes (#670)

* Initial plan

* Temporary: Set target framework to net8.0 for development

Co-authored-by: sebastienros <[email protected]>

* Fix: Quote foreign key constraint names to support numeric prefixes

Co-authored-by: sebastienros <[email protected]>

* Revert temporary TFM changes, restore net8.0;net10.0 targets

Co-authored-by: sebastienros <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: sebastienros <[email protected]>

Author: Copilot

src/YesSql.Core/Provider/BaseDialect.cs

@@ -136,7 +136,7 @@ public virtual string GetAddForeignKeyConstraintString(string name, string[] src
             }
 
             res.Append(" constraint ")
-                .Append(name)
+                .Append(QuoteForColumnName(name))
                 .Append(" foreign key (")
                 .AppendJoin(", ", srcColumns)
                 .Append(") references ")
@@ -154,7 +154,7 @@ public virtual string GetAddForeignKeyConstraintString(string name, string[] src
 
         public virtual string GetDropForeignKeyConstraintString(string name)
         {
-            return " drop constraint " + name;
+            return " drop constraint " + QuoteForColumnName(name);
         }
 
         public virtual bool SupportsIfExistsBeforeTableName => false;

src/YesSql.Provider.MySql/MySqlDialect.cs

@@ -191,7 +191,7 @@ public override string FormatIndexName(string name)
 
         public override string GetDropForeignKeyConstraintString(string name)
         {
-            return " drop foreign key " + FormatKeyName(name);
+            return " drop foreign key " + QuoteForColumnName(FormatKeyName(name));
         }
 
         public override string GetAddForeignKeyConstraintString(string name, string[] srcColumns, string destQuotedTable, string[] destColumns, bool primaryKey)

src/YesSql.Provider.PostgreSql/PostgreSqlDialect.cs

@@ -182,7 +182,7 @@ public override string FormatIndexName(string name)
         }  
         public override string GetDropForeignKeyConstraintString(string name)
         {
-            return " drop foreign key " + name;
+            return " drop constraint " + QuoteForColumnName(name);
         }
 
         public override string DefaultValuesInsert => "DEFAULT VALUES";

test/YesSql.Tests/PostgreSqlTests.cs

@@ -118,5 +118,42 @@ await builder.CreateReduceIndexTableAsync<PersonsByNameCol>(column => column
                 await transaction.CommitAsync();
             }
         }
+
+        [Fact]
+        public async Task ShouldQuoteForeignKeyConstraintsWithNumericPrefix()
+        {
+            // Test that foreign key constraints are properly quoted when table prefix starts with a digit
+            // This addresses: https://github.com/sebastienros/yessql/issues/XXX
+            var numericPrefixConfig = new Configuration()
+                .UsePostgreSql(ConnectionStringBuilder.ConnectionString, "BabyYoda")
+                .SetTablePrefix("1abcd_") // Prefix starting with a digit
+                .UseBlockIdGenerator()
+                .SetIdentityColumnSize(IdentityColumnSize.Int64);
+
+            using var store = await StoreFactory.CreateAndInitializeAsync(numericPrefixConfig);
+
+            await using var connection = store.Configuration.ConnectionFactory.CreateConnection();
+            await connection.OpenAsync();
+
+            await using (var transaction = await connection.BeginTransactionAsync(store.Configuration.IsolationLevel))
+            {
+                var builder = new SchemaBuilder(store.Configuration, transaction);
+
+                // This should not throw even with a numeric prefix
+                await builder.CreateMapIndexTableAsync<PersonByName>(column => column
+                    .Column<string>(nameof(PersonByName.SomeName))
+                );
+
+                await transaction.CommitAsync();
+            }
+
+            // Clean up
+            await using (var transaction = await connection.BeginTransactionAsync(store.Configuration.IsolationLevel))
+            {
+                var builder = new SchemaBuilder(store.Configuration, transaction);
+                await builder.DropMapIndexTableAsync<PersonByName>();
+                await transaction.CommitAsync();
+            }
+        }
     }
 }