Skip to content

Commit ff221c5

Browse files
author
Sunita Prajapati
committed
refactor: removed used code
- removed unused code - refactored reset methode
1 parent 4e3f07b commit ff221c5

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

packages/plugins/plugin-amplitudeSession/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"@segment/analytics-react-native": "^2.18.0"
4949
},
5050
"devDependencies": {
51-
"@segment/analytics-react-native": "^2.18.0",
51+
"@segment/analytics-react-native": "^2.21.4",
5252
"@segment/analytics-rn-shared": "workspace:^",
5353
"@segment/sovran-react-native": "^1.1.0",
5454
"@types/jest": "^29.5.8",

packages/plugins/plugin-amplitudeSession/src/AmplitudeSessionPlugin.tsx

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,7 @@ export class AmplitudeSessionPlugin extends EventPlugin {
163163
this.sessionId = -1;
164164
this.eventSessionId = -1;
165165
this.lastEventTime = -1;
166-
await AsyncStorage.multiRemove([
167-
SESSION_ID_KEY,
168-
EVENT_SESSION_ID_KEY,
169-
LAST_EVENT_TIME_KEY,
170-
]);
166+
await AsyncStorage.removeItem(SESSION_ID_KEY);
171167
}
172168

173169
private insertSession = (event: SegmentEvent) => {
@@ -193,7 +189,6 @@ export class AmplitudeSessionPlugin extends EventPlugin {
193189

194190
private onBackground = () => {
195191
this.lastEventTime = Date.now();
196-
//this.saveSessionData();
197192
};
198193

199194
private onForeground = () => {
@@ -245,8 +240,6 @@ export class AmplitudeSessionPlugin extends EventPlugin {
245240
this.eventSessionId === -1 ? newSessionId : this.eventSessionId;
246241
this.lastEventTime = newSessionId;
247242

248-
//await this.saveSessionData();
249-
250243
console.log(`[AmplitudeSession] startNewSession -> ${newSessionId}`);
251244

252245
await this.trackSessionStart(newSessionId);
@@ -291,14 +284,6 @@ export class AmplitudeSessionPlugin extends EventPlugin {
291284
storedEventSessionId != null ? Number(storedEventSessionId) : -1;
292285
}
293286

294-
// private async saveSessionData() {
295-
// await AsyncStorage.setItem(SESSION_ID_KEY, this.sessionId.toString());
296-
// await AsyncStorage.setItem(
297-
// LAST_EVENT_TIME_KEY,
298-
// this.lastEventTime.toString()
299-
// );
300-
// }
301-
302287
// eslint-disable-next-line @typescript-eslint/no-explicit-any
303288
private disableAllIntegrations(integrations?: Record<string, any>) {
304289
// eslint-disable-next-line @typescript-eslint/no-explicit-any

packages/plugins/plugin-amplitudeSession/src/__tests__/AmplitudeSessionPlugin.test.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -681,11 +681,9 @@ describe('AmplitudeSessionPlugin', () => {
681681
expect(plugin.sessionId).toBe(-1);
682682
expect(plugin.lastEventTime).toBe(-1);
683683
expect(plugin.eventSessionId).toBe(-1);
684-
expect(mockAsyncStorage.multiRemove).toHaveBeenCalledWith([
685-
'previous_session_id',
686-
'event_session_id',
687-
'last_event_time',
688-
]);
684+
expect(mockAsyncStorage.removeItem).toHaveBeenCalledWith(
685+
'previous_session_id'
686+
);
689687
});
690688
});
691689

0 commit comments

Comments
 (0)