Patching Github Issue #171 (#176)

* Patching Github Issue #171

* Respect storageJson option when creating client

Author: neelkanth-kaushik

packages/core/lib/client.dart

@@ -19,7 +19,10 @@ Analytics createClient(Configuration configuration) {
     configuration = setFlushPolicies(configuration, defaultFlushPolicies);
   }
 
-  final analytics = Analytics(configuration, storeFactory());
+  final analytics = Analytics(
+    configuration,
+    storeFactory(storageJson: configuration.storageJson ?? true),
+  );
 
   if (configuration.debug) {
     analytics.addPlugin(EventLogger());

packages/core/lib/utils/store/io.dart

@@ -9,8 +9,11 @@ import 'package:segment_analytics/utils/store/store.dart';
 import 'package:path_provider/path_provider.dart';
 
 class StoreImpl with Store {
+  final bool storageJson;
+  StoreImpl({this.storageJson = true});
   @override
   Future<Map<String, dynamic>?> getPersisted(String key) {
+    if (!storageJson) return Future.value(null);
     return _readFile(key);
   }
 
@@ -19,8 +22,18 @@ class StoreImpl with Store {
 
   @override
   Future setPersisted(String key, Map<String, dynamic> value) {
+    if (!storageJson) return Future.value();
     return _writeFile(key, value);
   }
+  
+  @override
+  Future deletePersisted(String key) async {
+    if (!storageJson) return;
+    final file = File(await _fileName(key));
+    if (await file.exists()) {
+      await file.delete();
+    }
+  }
 
   Future _writeFile(String fileKey, Map<String, dynamic> data) async {
     RandomAccessFile file =

packages/core/lib/utils/store/store.dart

@@ -4,12 +4,14 @@ mixin Store {
   Future<Map<String, dynamic>?> getPersisted(String key);
 
   Future setPersisted(String key, Map<String, dynamic> value);
+  
+  Future deletePersisted(String key);
 
   Future get ready;
 
   void dispose();
 }
 
-StoreImpl storeFactory() {
-  return StoreImpl();
+StoreImpl storeFactory({bool storageJson = true}) {
+  return StoreImpl(storageJson: storageJson);
 }

packages/core/lib/utils/store/unsupported.dart

@@ -4,6 +4,8 @@ import 'package:segment_analytics/errors.dart';
 import 'store.dart';
 
 class StoreImpl with Store {
+  final bool storageJson;
+  StoreImpl({this.storageJson = true});
   @override
   Future<Map<String, dynamic>?> getPersisted(String key) {
     throw PlatformNotSupportedError();
@@ -16,9 +18,14 @@ class StoreImpl with Store {
   Future setPersisted(String key, Map<String, dynamic> value) {
     throw PlatformNotSupportedError();
   }
+  
+  @override
+  Future deletePersisted(String key) {
+    throw PlatformNotSupportedError();
+  }
 
   @override
   void dispose() {
     throw PlatformNotSupportedError();
   }
-}
+}

packages/core/lib/utils/store/web.dart

@@ -5,10 +5,13 @@ import 'package:segment_analytics/utils/store/store.dart';
 import 'package:web/web.dart' as web;
 
 class StoreImpl implements Store {
+  final bool storageJson;
+  StoreImpl({this.storageJson = true});
   web.Storage get localStorage => web.window.localStorage;
 
   @override
   Future<Map<String, dynamic>?> getPersisted(String key) {
+    if (!storageJson) return Future.value(null);
     return _readFromStorage(key);
   }
 
@@ -17,9 +20,17 @@ class StoreImpl implements Store {
 
   @override
   Future setPersisted(String key, Map<String, dynamic> value) {
+    if (!storageJson) return Future.value();
     _writeToStorage(key, value);
     return Future.value();
   }
+  
+  @override
+  Future deletePersisted(String key) {
+    if (!storageJson) return Future.value();
+    localStorage.removeItem(_getFileName(key));
+    return Future.value();
+  }
 
   String _getFileName(String fileKey) {
     return "analytics-flutter-$fileKey.json";

packages/core/pubspec.yaml

@@ -1,6 +1,6 @@
 name: segment_analytics
 description: The hassle-free way to add Segment analytics to your Flutter app.
-version: 1.1.8
+version: 1.1.9
 homepage: https://github.com/segmentio/analytics_flutter#readme
 repository: https://github.com/segmentio/analytics_flutter/tree/main/packages/core#readme
 issue_tracker: https://github.com/segmentio/analytics_flutter/issues