adding some test for ParseARN function and updating some more logic in connector.go

Author: pazhang-25

pkg/admin/connector.go

@@ -247,7 +247,7 @@ func GetKafkaCredentials(ctx context.Context, svc *secretsmanager.Client, secret
 		return creds, fmt.Errorf("Couldn't parse the ARN for secret: %s, error: %v", secretArn, err)
 	}
 
-	secretParts := strings.Split(arn.Resource, ":")
+	secretParts := strings.SplitN(arn.Resource, ":", 2) // Split into at most 2 parts for cases of multi-colon resources
 	if len(secretParts) < 2 {
 		return creds, fmt.Errorf("invalid resource format in ARN: %s", secretArn)
 	}

pkg/admin/connector_test.go

@@ -0,0 +1,68 @@
+package admin
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestParseARN(t *testing.T) {
+	tests := []struct {
+		name        string
+		input       string
+		expected    ARN
+		expectError bool
+	}{
+		{
+			name:  "valid secrets manager ARN",
+			input: "arn:aws:secretsmanager:us-west-2:123456789012:secret:mysecret-AbCdEf",
+			expected: ARN{
+				Partition: "aws",
+				Service:   "secretsmanager",
+				Region:    "us-west-2",
+				AccountID: "123456789012",
+				Resource:  "secret:mysecret-AbCdEf",
+			},
+			expectError: false,
+		},
+		{
+			name:  "ARN with colons in resource",
+			input: "arn:aws:secretsmanager:us-west-2:123456789012:secret:my-secret:version-123",
+			expected: ARN{
+				Partition: "aws",
+				Service:   "secretsmanager",
+				Region:    "us-west-2",
+				AccountID: "123456789012",
+				Resource:  "secret:my-secret:version-123",
+			},
+			expectError: false,
+		},
+		{
+			name:        "invalid ARN prefix",
+			input:       "invalid:aws:secretsmanager:us-west-2:123456789012:secret:test",
+			expectError: true,
+		},
+		{
+			name:        "too few parts",
+			input:       "arn:aws:secretsmanager",
+			expectError: true,
+		},
+		{
+			name:        "empty string",
+			input:       "",
+			expectError: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result, err := ParseARN(tt.input)
+			if tt.expectError {
+				assert.Error(t, err)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, tt.expected, result)
+			}
+		})
+	}
+}