Lint the Git hooks

- Bash “strict mode”
- address ShellCheck complaints
  - replace backticks with `$()`
  - don’t compare against `$?`

Author: sellout

scripts/pre-commit.bash

@@ -1,10 +1,9 @@
 #!/usr/bin/env bash
+set -euo pipefail
 
-echo "Running pre-commit hook from "`pwd`
-./scripts/test.sh
+echo "Running pre-commit hook from $(pwd)"
 
-# $? stores exit value of the last command
-if [ $? -ne 0 ]; then
+if ! ./scripts/test.sh; then
  echo "Tests must pass before commit!"
  exit 1
 fi

scripts/pre-push.bash

@@ -1,17 +1,16 @@
 #!/bin/bash
-# Run the following command in the root of your project to install this pre-push hook:
-# cp git-hooks/pre-push .git/hooks/pre-push; chmod 700 .git/hooks/pre-push
+set -euo pipefail
+
+# Run `./install-hooks.bash` to install this pre-push hook.
 
 # Check if we actually have commits to push
-commits=`git log @{u}..`
+commits=$(git log "@{u}..")
 if [ -z "$commits" ]; then
     exit 0
 fi
 
 CMD="./scripts/test.sh"
-eval $CMD
-RESULT=$?
-if [ $RESULT -ne 0 ]; then
+if ! "$CMD"; then
     echo "The git push operation was canceled because \`$CMD\` did not complete successfully."
     exit 1
 fi