fix(publish): encode git tag in API URI

Author: constantology

lib/publish.js

@@ -8,19 +8,20 @@ module.exports = async (pluginConfig, {options: {repositoryUrl}, nextRelease: {g
   const {gitlabToken, gitlabUrl, gitlabApiPathPrefix} = resolveConfig(pluginConfig);
   const repoId = getRepoId(gitlabUrl, repositoryUrl);
   const apiUrl = urlJoin(gitlabUrl, gitlabApiPathPrefix);
+  const gitTagEncoded = encodeURIComponent(gitTag);
 
   debug('repoId: %o', repoId);
   debug('release name: %o', gitTag);
   debug('release ref: %o', gitHead);
 
   debug('Update git tag %o with commit %o and release description', gitTag, gitHead);
-  await got.post(urlJoin(apiUrl, `/projects/${encodeURIComponent(repoId)}/repository/tags/${gitTag}/release`), {
+  await got.post(urlJoin(apiUrl, `/projects/${encodeURIComponent(repoId)}/repository/tags/${gitTagEncoded}/release`), {
     json: true,
     headers: {'PRIVATE-TOKEN': gitlabToken},
     body: {tag_name: gitTag, description: notes}, // eslint-disable-line camelcase
   });
 
   logger.log('Published GitLab release: %s', gitTag);
 
-  return {url: urlJoin(gitlabUrl, repoId, `/tags/${gitTag}`), name: 'GitHub release'};
+  return {url: urlJoin(gitlabUrl, repoId, `/tags/${gitTagEncoded}`), name: 'GitHub release'};
 };

test/publish.test.js

@@ -35,19 +35,20 @@ test.serial('Publish a release', async t => {
   const repo = 'test_repo';
   process.env.GITLAB_TOKEN = 'gitlab_token';
   const pluginConfig = {};
-  const nextRelease = {gitHead: '123', gitTag: 'v1.0.0', notes: 'Test release note body'};
+  const nextRelease = {gitHead: '123', gitTag: '@scope/v1.0.0', notes: 'Test release note body'};
   const options = {repositoryUrl: `https://gitlab.com/${owner}/${repo}.git`};
+  const gitTagEncoded = encodeURIComponent(nextRelease.gitTag);
 
   const gitlab = authenticate()
-    .post(`/projects/${owner}%2F${repo}/repository/tags/${nextRelease.gitTag}/release`, {
+    .post(`/projects/${owner}%2F${repo}/repository/tags/${gitTagEncoded}/release`, {
       tag_name: nextRelease.gitTag,
       description: nextRelease.notes,
     })
     .reply(200);
 
   const result = await publish(pluginConfig, {options, nextRelease, logger: t.context.logger});
 
-  t.is(result.url, `https://gitlab.com/${owner}/${repo}/tags/${nextRelease.gitTag}`);
+  t.is(result.url, `https://gitlab.com/${owner}/${repo}/tags/${gitTagEncoded}`);
   t.deepEqual(t.context.log.args[0], ['Published GitLab release: %s', nextRelease.gitTag]);
   t.true(gitlab.isDone());
 });