fix(Sdk): Remove obsolete TaskExecutionStrategyDefinition and TaskExecutionMode

fix(Sdk): Fix the GetComponent WorkflowDefinition extension to drastically increase performance

Signed-off-by: Charles d'Avernas <[email protected]>

Author: cdavernas

src/ServerlessWorkflow.Sdk/Extensions/WorkflowDefinitionExtensions.cs

@@ -12,9 +12,8 @@
 // limitations under the License.
 
 using ServerlessWorkflow.Sdk.Models;
-using Json.Pointer;
-using Neuroglia;
-using Neuroglia.Serialization.Json;
+using System.Collections;
+using System.Reflection;
 
 namespace ServerlessWorkflow.Sdk;
 
@@ -61,10 +60,24 @@ public static Uri BuildReferenceTo(this WorkflowDefinition workflow, TaskDefinit
     public static TComponent GetComponent<TComponent>(this WorkflowDefinition workflow, string path)
     {
         ArgumentException.ThrowIfNullOrWhiteSpace(path);
-        var jsonNode = JsonSerializer.Default.SerializeToNode(workflow)!;
-        var jsonPointer = JsonPointer.Parse(path);
-        if (!jsonPointer.TryEvaluate(jsonNode, out var matchNode) || matchNode == null) throw new NullReferenceException($"Failed to find a component definition of type '{typeof(TComponent).Name}' at '{path}'");
-        return JsonSerializer.Default.Deserialize<TComponent>(matchNode)!;
+        var pathSegments = path.Split('/', StringSplitOptions.RemoveEmptyEntries);
+        var currentObject = workflow as object;
+        foreach (var pathSegment in pathSegments)
+        {
+            if (currentObject!.GetType().IsEnumerable() && int.TryParse(pathSegment, out var index)) currentObject = ((IEnumerable)currentObject).OfType<object>().ToList().ElementAt(index);
+            else
+            {
+                var mapEntryType = currentObject.GetType().GetGenericType(typeof(MapEntry<,>));
+                if (mapEntryType == null)
+                {
+                    var property = currentObject.GetType().GetProperty(pathSegment, BindingFlags.Default | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.IgnoreCase) ?? throw new NullReferenceException($"Failed to find a component definition of type '{typeof(TComponent).Name}' at '{pathSegment}'");
+                    currentObject = property.GetValue(currentObject) ?? throw new NullReferenceException($"Failed to find a component definition of type '{typeof(TComponent).Name}' at '{path}'");
+                }
+                else currentObject = mapEntryType.GetProperty(nameof(MapEntry<string, object>.Value))!.GetValue(currentObject);
+            }
+        }
+        if (currentObject is not TComponent component) throw new InvalidCastException($"Component at '{path}' is not of type '{typeof(TComponent).Name}'");
+        return component;
     }
 
     /// <summary>

src/ServerlessWorkflow.Sdk/Models/TaskExecutionStrategyDefinition.cs

@@ -31,6 +31,6 @@ public record BranchingDefinition
     /// Gets/sets a boolean indicating whether or not the branches should compete each other. If `true` and if a branch completes, it will cancel all other branches then it will return its output as the task's output
     /// </summary>
     [DataMember(Name = "compete", Order = 1), JsonPropertyName("compete"), JsonPropertyOrder(1), YamlMember(Alias = "compete", Order = 1)]
-    public required virtual bool Compete { get; set; }
+    public virtual bool Compete { get; set; }
 
 }

src/ServerlessWorkflow.Sdk/Models/Tasks/BranchingDefinition.cs

@@ -12,6 +12,7 @@
 // limitations under the License.
 
 using ServerlessWorkflow.Sdk.IO;
+using System.Text;
 
 namespace ServerlessWorkflow.Sdk.UnitTests.Cases.IO;
 
@@ -31,8 +32,6 @@ public async Task WriteThenRead_Workflow_Definition_ToFrom_Yaml_Should_Work()
         await writer.WriteAsync(toSerialize, stream, WorkflowDefinitionFormat.Yaml);
         await stream.FlushAsync();
         stream.Position = 0;
-        var yaml = new StreamReader(stream).ReadToEnd();
-        stream.Position = 0;
         var deserialized = await reader.ReadAsync(stream);
 
         //assert