Skip to content

Commit bb07f81

Browse files
authored
Merge pull request #16 from vibrato/version-fix
Changed to follow Cobra convention for version flag on cli
2 parents f817f1d + c675903 commit bb07f81

File tree

4 files changed

+3
-43
lines changed

4 files changed

+3
-43
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
mkdir output
3232
go build -v -o TechTestApp .
3333
ls
34-
./TechTestApp version | sed -e 's/Version: /v./' > versionfile
34+
./TechTestApp --version | sed -e 's/TechTestApp version /v./' > versionfile
3535
3636
3737
- run:

cmd/root.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ var rootCmd = &cobra.Command{
5454
This application is used as part of testing potential candiates at Vibrato.
5555
5656
Please visit http://vibrato.com.au for more details`,
57+
Version: "0.3.1",
5758
}
5859

5960
// Execute adds all child commands to the root command and sets flags appropriately.

cmd/version.go

Lines changed: 0 additions & 41 deletions
This file was deleted.

doc/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ Continuous integration is managed through circleci and the build on the master b
120120

121121
Releases are deployed and managed through github, it's an automated process that is executed through the CI solution
122122

123-
To create a new release, update `../cmd/version.go` with the new version and merge that into the master branch.
123+
To create a new release, update `../cmd/root.go` with the new version and merge that into the master branch.
124124

125125
The commit message on the merge, will be the release message, so make sure it contains the release notes.
126126

0 commit comments

Comments
 (0)