Skip to content

ToggleGroup unused class data-[spacing=default]:data-[variant=outline]:shadow-xs #8580

New issue
New issue
Open
#8632
Open
ToggleGroup unused class data-[spacing=default]:data-[variant=outline]:shadow-xs#8580
#8632
@ctison

Description

@ctison
ctison
opened on Oct 26, 2025

ui/apps/v4/registry/new-york-v4/ui/toggle-group.tsx

Lines 10 to 43 in 4f617d5

const ToggleGroupContext = React.createContext<
VariantProps<typeof toggleVariants> & {
spacing?: number
}
>({
size: "default",
variant: "default",
spacing: 0,
})
function ToggleGroup({
className,
variant,
size,
spacing = 0,
children,
...props
}: React.ComponentProps<typeof ToggleGroupPrimitive.Root> &
VariantProps<typeof toggleVariants> & {
spacing?: number
}) {
return (
<ToggleGroupPrimitive.Root
data-slot="toggle-group"
data-variant={variant}
data-size={size}
data-spacing={spacing}
style={{ "--gap": spacing } as React.CSSProperties}
className={cn(
"group/toggle-group flex w-fit items-center gap-[--spacing(var(--gap))] rounded-md data-[spacing=default]:data-[variant=outline]:shadow-xs",
className
)}
{...props}
>

Observations

  • data-spacing is referenced by data-[spacing=default]:data-[variant=outline]:shadow-xs
  • data-spacing={spacing}
  • spacing = 0 by default

Question

Should data-spacing={spacing} be:

  1. default when 0 or undefined
- data-spacing={spacing}
+ data-spacing={spacing || 'default'}
  1. default when undefined
- data-spacing={spacing}
+ data-spacing={spacing ?? 'default'}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions