java: Clean up javadoc issues

Author: jrose-signal

java/client/src/main/java/org/signal/libsignal/cds2/Cds2Client.java

@@ -16,7 +16,7 @@
 /**
  * Cds2Client provides bindings to interact with Signal's v2 Contact Discovery Service.
  *
- * <p>{@inheritDoc}
+ * <p>See the {@link SgxClient} docs for more information.
  *
  * <p>A future update to Cds2Client will implement additional parts of the contact discovery
  * protocol.

java/client/src/main/java/org/signal/libsignal/net/KeyTransparencyClient.java

@@ -72,10 +72,10 @@ public class KeyTransparencyClient {
    * <ul>
    *   <li>{@link ChatServiceException} for errors related to communication with the server.
    *       Depending on the severity, the search can be retried.
-   *   <li>{@link KeyTransparencyException} for errors related to key transparency logic, which
-   *       includes missing required fields in the serialized data. Retrying the search without
-   *       changing any of the arguments (including the state of the store) is unlikely to yield a
-   *       different result.
+   *   <li>{@link org.signal.libsignal.keytrans.KeyTransparencyException} for errors related to key
+   *       transparency logic, which includes missing required fields in the serialized data.
+   *       Retrying the search without changing any of the arguments (including the state of the
+   *       store) is unlikely to yield a different result.
    *   <li>{@link org.signal.libsignal.keytrans.VerificationFailedException} indicates a failure to
    *       verify the data in key transparency server response, such as an incorrect proof or a
    *       wrong signature.
@@ -147,9 +147,9 @@ public CompletableFuture<Void> search(
    * <ul>
    *   <li>{@link ChatServiceException} for errors related to communication with the server.
    *       Depending on the severity, the request can be retried.
-   *   <li>{@link KeyTransparencyException} for the errors related to key transparency logic.
-   *       Retrying the search without changing any of the arguments (including the state of the
-   *       store) is unlikely to produce a different result.
+   *   <li>{@link org.signal.libsignal.keytrans.KeyTransparencyException} for errors related to key
+   *       transparency logic. Retrying the search without changing any of the arguments (including
+   *       the state of the store) is unlikely to yield a different result.
    * </ul>
    *
    * @param store local persistent storage for key transparency related data, such as the latest
@@ -201,10 +201,10 @@ public CompletableFuture<Void> updateDistinguished(final Store store) {
    * <ul>
    *   <li>{@link ChatServiceException} for errors related to communication with the server.
    *       Depending on the severity, the search can be retried.
-   *   <li>{@link KeyTransparencyException} for errors related to key transparency logic, which
-   *       includes missing required fields in the serialized data. Retrying the search without
-   *       changing any of the arguments (including the state of the store) is unlikely to yield a
-   *       different result.
+   *   <li>{@link org.signal.libsignal.keytrans.KeyTransparencyException} for errors related to key
+   *       transparency logic, which includes missing required fields in the serialized data.
+   *       Retrying the search without changing any of the arguments (including the state of the
+   *       store) is unlikely to yield a different result.
    *   <li>{@link org.signal.libsignal.keytrans.VerificationFailedException} indicates a failure to
    *       verify the data in key transparency server response, such as an incorrect proof or a
    *       wrong signature.

java/client/src/main/java/org/signal/libsignal/svr2/Svr2Client.java

@@ -16,9 +16,7 @@
 /**
  * Svr2Client provides bindings to interact with Signal's v2 Secure Value Recovery service.
  *
- * <p>
- *
- * <p>{@inheritDoc}
+ * <p>See the {@link SgxClient} docs for more information.
  */
 public class Svr2Client extends SgxClient {
   public Svr2Client(byte[] mrenclave, byte[] attestationMsg, Instant currentInstant)

java/shared/java/org/signal/libsignal/protocol/SignalProtocolAddress.java

@@ -21,7 +21,7 @@ public SignalProtocolAddress(String name, int deviceId) {
   }
 
   /**
-   * @param name the identifier for the recipient
+   * @param serviceId the identifier for the recipient
    * @param deviceId the identifier for the device; must be in the range 1-127 inclusive
    */
   public SignalProtocolAddress(ServiceId serviceId, int deviceId) {