Various tweaks to the Julia code#17
Merged
honnatht merged 7 commits intosingular-gpispace:mainfrom Mar 9, 2025
Merged
Conversation
Contributor
Author
|
Tests are failing, will check and fix |
fingolfin
force-pushed
the
mh/tweaks
branch
2 times, most recently
from
ff3b3fa to
f726bb7
Compare
Contributor
Author
|
I was really confused because all tests pass for me locally, but I now realized this was still testing against Oscar 1.0 (not 1.3) due to the |
Contributor
Author
|
I think this is ready for merging now |
E.g. use list comprehensions `[f(x) for x in vec if prop(x)]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Julia code has many inefficiencies and unidiomatic code fragments.
I cleaned up a few of them here. For many of the changes in here, there are are other very similar places in the code base that could be transformed in a similar vein...