Skip to content

Why Minify_CSS::minify and CssMin::minify #56

@adoerler

Description

@adoerler

Hi,

if cssFileCompile is enabled, each file configured in the asset gets minified (using Minify_CSS::minify) at:
https://github.com/skeeks-semenov/yii2-assets-auto-compress/blob/master/src/AssetsAutoCompressComponent.php#L534

If cssFileCompress is enabled, it will get minified a few lines later again (using CssMin::minify):
https://github.com/skeeks-semenov/yii2-assets-auto-compress/blob/master/src/AssetsAutoCompressComponent.php#L568

I think complie should only concatenate the asset files into a single CSS file and it should compress this single CSS file only once and only if cssFileCompress is enabled.

What do you think?
Andreas

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions