-
Notifications
You must be signed in to change notification settings - Fork 846
use filename for uploaded files #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use filename for uploaded files #1774
Conversation
|
Thanks for the contribution! Before we can merge this, we need @codomposer to sign the Salesforce Inc. Contributor License Agreement. |
|
@mwbrooks |
|
hi @codomposer! thanks so much for submitting the PR! have you verified that the CLA was signed with the GitHub account you have submitted this PR with? |
yes, I signed with this account |
|
@codomposer could you push up another commit and see if it bumps the CLA check? |
Done |
|
@hello-ashleyintech I think closing and repopening PRs might also bump the @saleforce-cla[bot] for future reference 🤖 |
|
hi @hello-ashleyintech |
|
@codomposer hi, apologies for the delay! taking a look right now |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
=======================================
Coverage 84.35% 84.36%
=======================================
Files 115 115
Lines 12399 12399
=======================================
+ Hits 10459 10460 +1
+ Misses 1940 1939 -1 ☔ View full report in Codecov by Sentry. |

Summary
Fixes #1747
Testing
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.Contribution by Gittensor, learn more at https://gittensor.io/