Skip to content

Conversation

@codomposer
Copy link
Contributor

@codomposer codomposer commented Oct 30, 2025

Summary

Fixes #1747

Testing

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Contribution by Gittensor, learn more at https://gittensor.io/

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @codomposer to sign the Salesforce Inc. Contributor License Agreement.

@codomposer
Copy link
Contributor Author

@mwbrooks
I just signed the cla, but still it says missing? Can you take a look?
image

@hello-ashleyintech
Copy link
Contributor

hello-ashleyintech commented Oct 30, 2025

hi @codomposer!

thanks so much for submitting the PR! have you verified that the CLA was signed with the GitHub account you have submitted this PR with?

@hello-ashleyintech hello-ashleyintech self-requested a review October 30, 2025 19:02
@hello-ashleyintech hello-ashleyintech added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality semver:patch and removed bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented labels Oct 30, 2025
@codomposer
Copy link
Contributor Author

hi @codomposer!

thanks so much for submitting the PR! have you verified that the CLA was signed with the GitHub account you have submitted this PR with?

yes, I signed with this account

@hello-ashleyintech
Copy link
Contributor

@codomposer could you push up another commit and see if it bumps the CLA check?

@codomposer
Copy link
Contributor Author

@codomposer could you push up another commit and see if it bumps the CLA check?

Done

@zimeg
Copy link
Member

zimeg commented Oct 31, 2025

@hello-ashleyintech I think closing and repopening PRs might also bump the @saleforce-cla[bot] for future reference 🤖

@codomposer
Copy link
Contributor Author

hi @hello-ashleyintech
can you please check this PR?
\

@hello-ashleyintech
Copy link
Contributor

@codomposer hi, apologies for the delay! taking a look right now

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (c84c1af) to head (3897f26).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   84.35%   84.36%           
=======================================
  Files         115      115           
  Lines       12399    12399           
=======================================
+ Hits        10459    10460    +1     
+ Misses       1940     1939    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hello-ashleyintech hello-ashleyintech merged commit 0c21814 into slackapi:main Nov 11, 2025
25 checks passed
@zimeg zimeg added this to the 3.38.0 milestone Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed enhancement M-T: A feature request for new functionality semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploaded files don't uses the filename as the title

3 participants