-
Notifications
You must be signed in to change notification settings - Fork 846
ci: upload test results using the recommended codecov action #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📬 Writings to wonderful reviewers as always-
| uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1 | ||
| with: | ||
| directory: ./reports/ | ||
| fail_ci_if_error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ note: Similar to the changes of slackapi/bolt-python#1396 we're setting this to true with belief that the updated action is more stable!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
==========================================
+ Coverage 84.32% 84.36% +0.03%
==========================================
Files 115 115
Lines 12399 12399
==========================================
+ Hits 10456 10460 +4
+ Misses 1943 1939 -4 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💯
|
@WilliamBergamin Kind thanks! This is such an interesting action to investigate 🔍 ✨ |
Summary
This PR uses the recommended
codecov/codecov-actionto both upload test coverage and test results 🧪 ✨From the pages of the
codecov/test-results-actionaction:🔗 https://github.com/codecov/test-results-action?tab=readme-ov-file#%EF%B8%8F-deprecation-warning-%EF%B8%8F
Testing
Hopes to fix ongoing issues in CI:
⏳ https://github.com/slackapi/python-slack-sdk/actions/workflows/tests.yml?query=event%3Aschedule
🤖 https://github.com/slackapi/python-slack-sdk/actions/runs/19200481199/job/54887556261
Category
Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.