Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Nov 11, 2025

Summary

This PR uses the recommended codecov/codecov-action to both upload test coverage and test results 🧪 ✨

From the pages of the codecov/test-results-action action:

⚠️ Deprecation Warning ⚠️

This Action causes issues for users uploading test analytics to Codecov

🔗 https://github.com/codecov/test-results-action?tab=readme-ov-file#%EF%B8%8F-deprecation-warning-%EF%B8%8F

Testing

Hopes to fix ongoing issues in CI:

https://github.com/slackapi/python-slack-sdk/actions/workflows/tests.yml?query=event%3Aschedule
🤖 https://github.com/slackapi/python-slack-sdk/actions/runs/19200481199/job/54887556261

Category

  • Other

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimeg zimeg self-assigned this Nov 11, 2025
@zimeg zimeg added semver:patch github_actions Pull requests that update GitHub Actions code dependencies Pull requests that update a dependency file labels Nov 11, 2025
Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📬 Writings to wonderful reviewers as always-

uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
with:
directory: ./reports/
fail_ci_if_error: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ note: Similar to the changes of slackapi/bolt-python#1396 we're setting this to true with belief that the updated action is more stable!

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (0c21814) to head (676a2cf).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
+ Coverage   84.32%   84.36%   +0.03%     
==========================================
  Files         115      115              
  Lines       12399    12399              
==========================================
+ Hits        10456    10460       +4     
+ Misses       1943     1939       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@zimeg zimeg enabled auto-merge (squash) November 11, 2025 16:52
@zimeg
Copy link
Member Author

zimeg commented Nov 11, 2025

@WilliamBergamin Kind thanks! This is such an interesting action to investigate 🔍 ✨

@zimeg zimeg merged commit 9e08903 into main Nov 11, 2025
14 checks passed
@zimeg zimeg deleted the zimeg-ci-codecov-action branch November 11, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants