Skip to content

Commit 95e57c6

Browse files
committed
Fixed stall on context unload
1 parent ea4e083 commit 95e57c6

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

src/Piral.Blazor.Orchestrator/MfComponentService.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ public MfComponentService(IMfRepository repository)
1414
_repository.PackagesChanged += OnPackagesChanged;
1515
}
1616

17-
private void OnPackagesChanged(object? sender, EventArgs e) => ComponentsChanged?.Invoke(this, e);
17+
private void OnPackagesChanged(object? sender, EventArgs e)
18+
{
19+
ComponentsChanged?.Invoke(this, e);
20+
}
1821

1922
private IEnumerable<MicrofrontendPackage> ActivePackages => _repository.Packages.Where(m => !m.IsDisabled);
2023

src/Piral.Blazor.Orchestrator/MfRepository.cs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,14 @@ public async Task DeletePackage(string name)
2121
package.PackageChanged -= NotifyPackagesChanged;
2222
_microfrontends.Remove(package);
2323
await package.Destroy();
24-
package.Dispose();
2524
}
2625

2726
NotifyPackagesChanged(this, EventArgs.Empty);
27+
28+
foreach (var package in packages)
29+
{
30+
package.Dispose();
31+
}
2832
}
2933
}
3034

@@ -53,5 +57,8 @@ public void Dispose()
5357
_microfrontends.Clear();
5458
}
5559

56-
private void NotifyPackagesChanged(object? sender, EventArgs e) => PackagesChanged?.Invoke(sender, e);
60+
private void NotifyPackagesChanged(object? sender, EventArgs e)
61+
{
62+
PackagesChanged?.Invoke(sender, e);
63+
}
5764
}

src/Piral.Blazor.Orchestrator/MicrofrontendPackage.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using Microsoft.AspNetCore.Components;
2-
using NuGet.Frameworks;
32
using Piral.Blazor.Shared;
43
using System.Reflection;
54
using System.Runtime.Loader;

0 commit comments

Comments
 (0)