Skip to content

Commit af5c5d4

Browse files
committed
Fixed the error 'module' object is not callable in csvsql when loading Snowflake SQLAlchemy dialect
1 parent a8ef278 commit af5c5d4

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
},
5151
entry_points={
5252
'sqlalchemy.dialects': [
53-
'snowflake=snowflake.sqlalchemy.base',
53+
'snowflake=snowflake.sqlalchemy.base:SnowflakeDialect',
5454
]
5555
},
5656
classifiers = [

test/test_core.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@
1212
Sequence, ForeignKey, Binary, REAL)
1313
from sqlalchemy import inspect
1414
from sqlalchemy import text
15+
from sqlalchemy import dialects
1516
from sqlalchemy.sql import and_, or_, not_
1617
from sqlalchemy.sql import select
1718

1819
from snowflake.sqlalchemy import URL
20+
from snowflake.sqlalchemy.base import SnowflakeDialect
1921

2022
try:
2123
from parameters import (CONNECTION_PARAMETERS2)
@@ -794,3 +796,10 @@ def test_azure():
794796
assert 'Failed to connect to DB' in ex.orig.msg
795797
assert 'testaccount.east-us-2.azure.snowflakecomputing.com' in \
796798
ex.orig.msg
799+
800+
801+
def test_load_dialect():
802+
"""
803+
Test loading Snowflake SQLAlchemy dialect class
804+
"""
805+
assert isinstance(dialects.registry.load('snowflake')(), SnowflakeDialect)

test/test_pandas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def get_engine_with_numpy(db_parameters, user=None, password=None,
111111
def test_numpy_datatypes(db_parameters):
112112
engine = get_engine_with_numpy(db_parameters)
113113
try:
114-
specific_date = np.datetime64('2016-03-04T12:03:05.123456789Z')
114+
specific_date = np.datetime64('2016-03-04T12:03:05.123456789')
115115
engine.execute(
116116
"CREATE OR REPLACE TABLE {name}("
117117
"c1 timestamp_ntz)".format(name=db_parameters['name']))

0 commit comments

Comments
 (0)