Added multivalue_insert support

Author: smtakeda

base.py

@@ -423,8 +423,8 @@ class SnowflakeDialect(default.DefaultDialect):
 
     # The dialect supports a native ENUM construct.
     supports_native_enum = False
-    
-    # The dialect supports inserting multiple rows at once 
+
+    # The dialect supports inserting multiple rows at once.
     supports_multivalues_insert = True
 
     preparer = SnowflakeIdentifierPreparer
@@ -433,10 +433,8 @@ class SnowflakeDialect(default.DefaultDialect):
     statement_compiler = SnowflakeCompiler
     execution_ctx_cls = SnowflakeExecutionContext
 
-    # indicates symbol names are
-    # UPPERCASEd if they are case insensitive
-    # within the database.
-    # if this is True, the methods normalize_name()
+    # indicates symbol names are UPPERCASEd if they are case insensitive
+    # within the database. If this is True, the methods normalize_name()
     # and denormalize_name() must be provided.
     requires_name_normalize = True
 

test/test_core.py

@@ -160,9 +160,10 @@ def test_insert_tables(engine_testaccount):
     Inserts data into tables
     """
     metadata = MetaData()
-    users, addresses = _create_users_addresses_tables(engine_testaccount,
-                                                      metadata)
+    users, addresses = _create_users_addresses_tables(
+        engine_testaccount, metadata)
 
+    conn = engine_testaccount.connect()
     try:
         # inserts data with an implicitly generated id
         ins = users.insert().values(name='jack', fullname='Jack Jones')
@@ -171,7 +172,6 @@ def test_insert_tables(engine_testaccount):
         results.close()
 
         # inserts data with the given id
-        conn = engine_testaccount.connect()
         ins = users.insert()
         conn.execute(ins, id=2, name='wendy', fullname='Wendy Williams')
 
@@ -312,6 +312,7 @@ def test_insert_tables(engine_testaccount):
         results = engine_testaccount.execute(s).fetchall()
         assert results[-1] == ('Wendy Williams',)
     finally:
+        conn.close()
         # drop tables
         addresses.drop(engine_testaccount)
         users.drop(engine_testaccount)

test/test_multivalues_insert.py

@@ -0,0 +1,41 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#
+# Copyright (c) 2012-2018 Snowflake Computing Inc. All right reserved.
+#
+
+from sqlalchemy import (Integer, String, Sequence)
+from sqlalchemy.schema import (Table, Column, MetaData)
+from sqlalchemy.sql import select
+
+
+def test_insert_table(engine_testaccount):
+    metadata = MetaData()
+    users = Table('users', metadata,
+                  Column('id', Integer, Sequence('user_id_seq'),
+                         primary_key=True),
+                  Column('name', String),
+                  Column('fullname', String),
+                  )
+    metadata.create_all(engine_testaccount)
+
+    data = [{
+        'id': 1,
+        'name': 'testname1',
+        'fullname': 'fulltestname1',
+    }, {
+        'id': 2,
+        'name': 'testname2',
+        'fullname': 'fulltestname2',
+    }]
+    conn = engine_testaccount.connect()
+    try:
+        # using multivalue insert
+        conn.execute(users.insert(data))
+        results = conn.execute(select([users]).order_by('id'))
+        row = results.fetchone()
+        assert row['name'] == 'testname1'
+
+    finally:
+        conn.close()
+        users.drop(engine_testaccount)