Merge branch 'main' into feat/audio-recorder-to-file

Author: michalsek

packages/audiodocs/docs/core/base-audio-context.mdx

@@ -120,6 +120,16 @@ Creates [`ConvolverNode`](/docs/effects/convolver-node).
 
 #### Returns `ConvolverNode`.
 
+### `createDelay`
+
+Creates [`DelayNode`](/docs/effects/delay-node)
+
+| Parameter | Type | Description |
+| :---: | :---: | :---- |
+| `maxDelayTime` <Optional /> | `number` | Maximum amount of time to buffer delayed values|
+
+#### Returns `DelayNode`
+
 ### `createGain`
 
 Creates [`GainNode`](/docs/effects/gain-node).

packages/audiodocs/docs/effects/delay-node.mdx

@@ -0,0 +1,50 @@
+---
+sidebar_position: 5
+---
+
+import AudioNodePropsTable from "@site/src/components/AudioNodePropsTable"
+import { ReadOnly } from '@site/src/components/Badges';
+
+# DelayNode
+
+The `DelayNode` interface represents the latency of the audio signal by given time. It is an [`AudioNode`](/docs/core/audio-node) that applies time shift to incoming signal f.e.
+if `delayTime` value is 0.5, it means that audio will be played after 0.5 seconds.
+
+#### [`AudioNode`](/docs/core/audio-node#properties) properties
+
+<AudioNodePropsTable numberOfInputs={1} numberOfOutputs={1} channelCount={2} channelCountMode={"max"} channelInterpretation={"speakers"} />
+
+:::info
+Delay is a node with tail-time, which means, that it continues to output non-silent audio with zero input for the duration of `delayTime`.
+:::
+
+## Constructor
+
+[`BaseAudioContext.createDelay(maxDelayTime?: number)`](/docs/core/base-audio-context#createdelay)
+
+## Properties
+
+It inherits all properties from [`AudioNode`](/docs/core/audio-node#properties).
+
+| Name | Type | Description |
+| :----: | :----: | :-------- |
+| `delayTime`| <ReadOnly /> [`AudioParam`](/docs/core/audio-param) | [`k-rate`](/docs/core/audio-param#a-rate-vs-k-rate) `AudioParam` representing value of time shift to apply. |
+
+:::warning
+In web audio api specs `delayTime` is an `a-rate` param.
+:::
+
+## Methods
+
+`DelayNode` does not define any additional methods.
+It inherits all methods from [`AudioNode`](/docs/core/audio-node#methods).
+
+## Remarks
+
+#### `maxDelayTime`
+- Default value is 1.0.
+- Nominal range is 0 - 180.
+
+#### `delayTime`
+- Default value is 0.
+- Nominal range is 0 - `maxDelayTime`.

packages/audiodocs/docs/other/web-audio-api-coverage.mdx

@@ -1,3 +1,4 @@
+
 ---
 id: web-audio-api-coverage
 sidebar_label: Web Audio API coverage
@@ -20,6 +21,7 @@ sidebar_position: 2
 | BiquadFilterNode | ✅ |
 | ConstantSourceNode | ✅ |
 | ConvolverNode | ✅ |
+| DelayNode | ✅ |
 | GainNode | ✅ |
 | IIRFilterNode | ✅  |
 | OfflineAudioContext | ✅ |
@@ -36,7 +38,6 @@ sidebar_position: 2
 | AudioWorkletProcessor | ❌ |
 | ChannelMergerNode | ❌ |
 | ChannelSplitterNode | ❌ |
-| DelayNode | ❌ |
 | DynamicsCompressorNode | ❌ |
 | MediaElementAudioSourceNode | ❌ |
 | MediaStreamAudioDestinationNode | ❌ |

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/AudioAPIModule.cpp

@@ -50,7 +50,6 @@ void AudioAPIModule::registerNatives() {
       makeNativeMethod(
           "invokeHandlerWithEventNameAndEventBody",
           AudioAPIModule::invokeHandlerWithEventNameAndEventBody),
-      makeNativeMethod("closeAllContexts", AudioAPIModule::closeAllContexts),
   });
 }
 
@@ -96,8 +95,4 @@ void AudioAPIModule::invokeHandlerWithEventNameAndEventBody(
     audioEventHandlerRegistry_->invokeHandlerWithEventBody(eventName->toStdString(), body);
   }
 }
-
-void AudioAPIModule::closeAllContexts() {
-  AudioAPIModuleInstaller::closeAllContexts();
-}
 } // namespace audioapi

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/AudioAPIModule.h

@@ -34,7 +34,6 @@ class AudioAPIModule : public jni::HybridClass<AudioAPIModule> {
 
   void injectJSIBindings();
   void invokeHandlerWithEventNameAndEventBody(jni::alias_ref<jni::JString> eventName, jni::alias_ref<jni::JMap<jstring, jobject>> eventBody);
-  void closeAllContexts();
 
  private:
   friend HybridBase;

packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt

@@ -41,8 +41,6 @@ class AudioAPIModule(
     eventBody: Map<String, Any>,
   )
 
-  private external fun closeAllContexts()
-
   init {
     try {
       System.loadLibrary("react-native-audio-api")
@@ -79,15 +77,14 @@ class AudioAPIModule(
   }
 
   override fun onHostDestroy() {
-    closeAllContexts()
+    // do nothing
   }
 
   override fun initialize() {
     reactContext.get()?.addLifecycleEventListener(this)
   }
 
   override fun invalidate() {
-    closeAllContexts()
     reactContext.get()?.removeLifecycleEventListener(this)
     // think about cleaning up resources, singletons etc.
   }

packages/react-native-audio-api/common/cpp/audioapi/AudioAPIModuleInstaller.h

@@ -24,9 +24,6 @@ namespace audioapi {
 using namespace facebook;
 
 class AudioAPIModuleInstaller {
- private:
-  inline static std::vector<std::weak_ptr<AudioContext>> contexts_ = {};
-
  public:
   static void injectJSIBindings(
       jsi::Runtime *jsiRuntime,
@@ -57,19 +54,6 @@ class AudioAPIModuleInstaller {
         jsi::Object::createFromHostObject(*jsiRuntime, audioEventHandlerRegistryHostObject));
   }
 
-  static void closeAllContexts() {
-    for (auto it = contexts_.begin(); it != contexts_.end(); ++it) {
-      auto weakContext = *it;
-
-      if (auto context = weakContext.lock()) {
-        context->close();
-      }
-
-      it = contexts_.erase(it);
-      --it;
-    }
-  }
-
  private:
   static jsi::Function getCreateAudioContextFunction(
       jsi::Runtime *jsiRuntime,
@@ -98,7 +82,6 @@ class AudioAPIModuleInstaller {
 
           audioContext = std::make_shared<AudioContext>(
               sampleRate, audioEventHandlerRegistry, runtimeRegistry);
-          AudioAPIModuleInstaller::contexts_.push_back(audioContext);
 
           auto audioContextHostObject =
               std::make_shared<AudioContextHostObject>(audioContext, &runtime, jsCallInvoker);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp

@@ -6,6 +6,7 @@
 #include <audioapi/HostObjects/destinations/AudioDestinationNodeHostObject.h>
 #include <audioapi/HostObjects/effects/BiquadFilterNodeHostObject.h>
 #include <audioapi/HostObjects/effects/ConvolverNodeHostObject.h>
+#include <audioapi/HostObjects/effects/DelayNodeHostObject.h>
 #include <audioapi/HostObjects/effects/GainNodeHostObject.h>
 #include <audioapi/HostObjects/effects/IIRFilterNodeHostObject.h>
 #include <audioapi/HostObjects/effects/PeriodicWaveHostObject.h>
@@ -47,6 +48,7 @@ BaseAudioContextHostObject::BaseAudioContextHostObject(
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createStreamer),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createConstantSource),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createGain),
+      JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createDelay),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createStereoPanner),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createBiquadFilter),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createIIRFilter),
@@ -184,6 +186,15 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createGain) {
   return jsi::Object::createFromHostObject(runtime, gainHostObject);
 }
 
+JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createDelay) {
+  auto maxDelayTime = static_cast<float>(args[0].getNumber());
+  auto delayNode = context_->createDelay(maxDelayTime);
+  auto delayNodeHostObject = std::make_shared<DelayNodeHostObject>(delayNode);
+  auto jsiObject = jsi::Object::createFromHostObject(runtime, delayNodeHostObject);
+  jsiObject.setExternalMemoryPressure(runtime, delayNodeHostObject->getSizeInBytes());
+  return jsiObject;
+}
+
 JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createStereoPanner) {
   auto stereoPanner = context_->createStereoPanner();
   auto stereoPannerHostObject = std::make_shared<StereoPannerNodeHostObject>(stereoPanner);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.h

@@ -43,6 +43,7 @@ class BaseAudioContextHostObject : public JsiHostObject {
   JSI_HOST_FUNCTION_DECL(createPeriodicWave);
   JSI_HOST_FUNCTION_DECL(createAnalyser);
   JSI_HOST_FUNCTION_DECL(createConvolver);
+  JSI_HOST_FUNCTION_DECL(createDelay);
 
   std::shared_ptr<BaseAudioContext> context_;
 

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/DelayNodeHostObject.cpp

@@ -0,0 +1,27 @@
+#include <audioapi/HostObjects/effects/DelayNodeHostObject.h>
+
+#include <audioapi/HostObjects/AudioParamHostObject.h>
+#include <audioapi/core/BaseAudioContext.h>
+#include <audioapi/core/effects/DelayNode.h>
+#include <memory>
+
+namespace audioapi {
+
+DelayNodeHostObject::DelayNodeHostObject(const std::shared_ptr<DelayNode> &node)
+    : AudioNodeHostObject(node) {
+  addGetters(JSI_EXPORT_PROPERTY_GETTER(DelayNodeHostObject, delayTime));
+}
+
+size_t DelayNodeHostObject::getSizeInBytes() const {
+  auto delayNode = std::static_pointer_cast<DelayNode>(node_);
+  return sizeof(float) * delayNode->context_->getSampleRate() *
+      delayNode->getDelayTimeParam()->getMaxValue();
+}
+
+JSI_PROPERTY_GETTER_IMPL(DelayNodeHostObject, delayTime) {
+  auto delayNode = std::static_pointer_cast<DelayNode>(node_);
+  auto delayTimeParam = std::make_shared<AudioParamHostObject>(delayNode->getDelayTimeParam());
+  return jsi::Object::createFromHostObject(runtime, delayTimeParam);
+}
+
+} // namespace audioapi