refactor: removed close all contexts method (#825)

Co-authored-by: maciejmakowski2003 <[email protected]>

Author: maciejmakowski2003

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/AudioAPIModule.cpp

@@ -50,7 +50,6 @@ void AudioAPIModule::registerNatives() {
       makeNativeMethod(
           "invokeHandlerWithEventNameAndEventBody",
           AudioAPIModule::invokeHandlerWithEventNameAndEventBody),
-      makeNativeMethod("closeAllContexts", AudioAPIModule::closeAllContexts),
   });
 }
 
@@ -96,8 +95,4 @@ void AudioAPIModule::invokeHandlerWithEventNameAndEventBody(
     audioEventHandlerRegistry_->invokeHandlerWithEventBody(eventName->toStdString(), body);
   }
 }
-
-void AudioAPIModule::closeAllContexts() {
-  AudioAPIModuleInstaller::closeAllContexts();
-}
 } // namespace audioapi

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/AudioAPIModule.h

@@ -34,7 +34,6 @@ class AudioAPIModule : public jni::HybridClass<AudioAPIModule> {
 
   void injectJSIBindings();
   void invokeHandlerWithEventNameAndEventBody(jni::alias_ref<jni::JString> eventName, jni::alias_ref<jni::JMap<jstring, jobject>> eventBody);
-  void closeAllContexts();
 
  private:
   friend HybridBase;

packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt

@@ -40,8 +40,6 @@ class AudioAPIModule(
     eventBody: Map<String, Any>,
   )
 
-  private external fun closeAllContexts()
-
   init {
     try {
       System.loadLibrary("react-native-audio-api")
@@ -77,15 +75,14 @@ class AudioAPIModule(
   }
 
   override fun onHostDestroy() {
-    closeAllContexts()
+    // do nothing
   }
 
   override fun initialize() {
     reactContext.get()?.addLifecycleEventListener(this)
   }
 
   override fun invalidate() {
-    closeAllContexts()
     reactContext.get()?.removeLifecycleEventListener(this)
     // think about cleaning up resources, singletons etc.
   }

packages/react-native-audio-api/common/cpp/audioapi/AudioAPIModuleInstaller.h

@@ -23,9 +23,6 @@ namespace audioapi {
 using namespace facebook;
 
 class AudioAPIModuleInstaller {
- private:
-  inline static std::vector<std::weak_ptr<AudioContext>> contexts_ = {};
-
  public:
   static void injectJSIBindings(
       jsi::Runtime *jsiRuntime,
@@ -56,19 +53,6 @@ class AudioAPIModuleInstaller {
         jsi::Object::createFromHostObject(*jsiRuntime, audioEventHandlerRegistryHostObject));
   }
 
-  static void closeAllContexts() {
-    for (auto it = contexts_.begin(); it != contexts_.end(); ++it) {
-      auto weakContext = *it;
-
-      if (auto context = weakContext.lock()) {
-        context->close();
-      }
-
-      it = contexts_.erase(it);
-      --it;
-    }
-  }
-
  private:
   static jsi::Function getCreateAudioContextFunction(
       jsi::Runtime *jsiRuntime,
@@ -97,7 +81,6 @@ class AudioAPIModuleInstaller {
 
           audioContext = std::make_shared<AudioContext>(
               sampleRate, audioEventHandlerRegistry, runtimeRegistry);
-          AudioAPIModuleInstaller::contexts_.push_back(audioContext);
 
           auto audioContextHostObject =
               std::make_shared<AudioContextHostObject>(audioContext, &runtime, jsCallInvoker);

packages/react-native-audio-api/ios/audioapi/ios/AudioAPIModule.mm

@@ -54,8 +54,6 @@ - (void)invalidate
 
   _eventHandler = nullptr;
 
-  audioapi::AudioAPIModuleInstaller::closeAllContexts();
-
   [super invalidate];
 }