Merge branch 'main' into feat/wave-shaper

Author: maciejmakowski2003

packages/audiodocs/docs/core/base-audio-context.mdx

@@ -120,6 +120,16 @@ Creates [`ConvolverNode`](/docs/effects/convolver-node).
 
 #### Returns `ConvolverNode`.
 
+### `createDelay`
+
+Creates [`DelayNode`](/docs/effects/delay-node)
+
+| Parameter | Type | Description |
+| :---: | :---: | :---- |
+| `maxDelayTime` <Optional /> | `number` | Maximum amount of time to buffer delayed values|
+
+#### Returns `DelayNode`
+
 ### `createGain`
 
 Creates [`GainNode`](/docs/effects/gain-node).

packages/audiodocs/docs/effects/delay-node.mdx

@@ -0,0 +1,50 @@
+---
+sidebar_position: 5
+---
+
+import AudioNodePropsTable from "@site/src/components/AudioNodePropsTable"
+import { ReadOnly } from '@site/src/components/Badges';
+
+# DelayNode
+
+The `DelayNode` interface represents the latency of the audio signal by given time. It is an [`AudioNode`](/docs/core/audio-node) that applies time shift to incoming signal f.e.
+if `delayTime` value is 0.5, it means that audio will be played after 0.5 seconds.
+
+#### [`AudioNode`](/docs/core/audio-node#properties) properties
+
+<AudioNodePropsTable numberOfInputs={1} numberOfOutputs={1} channelCount={2} channelCountMode={"max"} channelInterpretation={"speakers"} />
+
+:::info
+Delay is a node with tail-time, which means, that it continues to output non-silent audio with zero input for the duration of `delayTime`.
+:::
+
+## Constructor
+
+[`BaseAudioContext.createDelay(maxDelayTime?: number)`](/docs/core/base-audio-context#createdelay)
+
+## Properties
+
+It inherits all properties from [`AudioNode`](/docs/core/audio-node#properties).
+
+| Name | Type | Description |
+| :----: | :----: | :-------- |
+| `delayTime`| <ReadOnly /> [`AudioParam`](/docs/core/audio-param) | [`k-rate`](/docs/core/audio-param#a-rate-vs-k-rate) `AudioParam` representing value of time shift to apply. |
+
+:::warning
+In web audio api specs `delayTime` is an `a-rate` param.
+:::
+
+## Methods
+
+`DelayNode` does not define any additional methods.
+It inherits all methods from [`AudioNode`](/docs/core/audio-node#methods).
+
+## Remarks
+
+#### `maxDelayTime`
+- Default value is 1.0.
+- Nominal range is 0 - 180.
+
+#### `delayTime`
+- Default value is 0.
+- Nominal range is 0 - `maxDelayTime`.

packages/audiodocs/docs/other/web-audio-api-coverage.mdx

@@ -1,3 +1,4 @@
+
 ---
 id: web-audio-api-coverage
 sidebar_label: Web Audio API coverage
@@ -20,6 +21,7 @@ sidebar_position: 2
 | BiquadFilterNode | ✅ |
 | ConstantSourceNode | ✅ |
 | ConvolverNode | ✅ |
+| DelayNode | ✅ |
 | GainNode | ✅ |
 | IIRFilterNode | ✅  |
 | OfflineAudioContext | ✅ |
@@ -37,7 +39,6 @@ sidebar_position: 2
 | AudioWorkletProcessor | ❌ |
 | ChannelMergerNode | ❌ |
 | ChannelSplitterNode | ❌ |
-| DelayNode | ❌ |
 | DynamicsCompressorNode | ❌ |
 | MediaElementAudioSourceNode | ❌ |
 | MediaStreamAudioDestinationNode | ❌ |

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp

@@ -6,6 +6,7 @@
 #include <audioapi/HostObjects/destinations/AudioDestinationNodeHostObject.h>
 #include <audioapi/HostObjects/effects/BiquadFilterNodeHostObject.h>
 #include <audioapi/HostObjects/effects/ConvolverNodeHostObject.h>
+#include <audioapi/HostObjects/effects/DelayNodeHostObject.h>
 #include <audioapi/HostObjects/effects/GainNodeHostObject.h>
 #include <audioapi/HostObjects/effects/IIRFilterNodeHostObject.h>
 #include <audioapi/HostObjects/effects/PeriodicWaveHostObject.h>
@@ -48,6 +49,7 @@ BaseAudioContextHostObject::BaseAudioContextHostObject(
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createStreamer),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createConstantSource),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createGain),
+      JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createDelay),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createStereoPanner),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createBiquadFilter),
       JSI_EXPORT_FUNCTION(BaseAudioContextHostObject, createIIRFilter),
@@ -186,6 +188,15 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createGain) {
   return jsi::Object::createFromHostObject(runtime, gainHostObject);
 }
 
+JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createDelay) {
+  auto maxDelayTime = static_cast<float>(args[0].getNumber());
+  auto delayNode = context_->createDelay(maxDelayTime);
+  auto delayNodeHostObject = std::make_shared<DelayNodeHostObject>(delayNode);
+  auto jsiObject = jsi::Object::createFromHostObject(runtime, delayNodeHostObject);
+  jsiObject.setExternalMemoryPressure(runtime, delayNodeHostObject->getSizeInBytes());
+  return jsiObject;
+}
+
 JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createStereoPanner) {
   auto stereoPanner = context_->createStereoPanner();
   auto stereoPannerHostObject = std::make_shared<StereoPannerNodeHostObject>(stereoPanner);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.h

@@ -44,6 +44,7 @@ class BaseAudioContextHostObject : public JsiHostObject {
   JSI_HOST_FUNCTION_DECL(createAnalyser);
   JSI_HOST_FUNCTION_DECL(createConvolver);
   JSI_HOST_FUNCTION_DECL(createWaveShaper);
+  JSI_HOST_FUNCTION_DECL(createDelay);
 
   std::shared_ptr<BaseAudioContext> context_;
 

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/DelayNodeHostObject.cpp

@@ -0,0 +1,27 @@
+#include <audioapi/HostObjects/effects/DelayNodeHostObject.h>
+
+#include <audioapi/HostObjects/AudioParamHostObject.h>
+#include <audioapi/core/BaseAudioContext.h>
+#include <audioapi/core/effects/DelayNode.h>
+#include <memory>
+
+namespace audioapi {
+
+DelayNodeHostObject::DelayNodeHostObject(const std::shared_ptr<DelayNode> &node)
+    : AudioNodeHostObject(node) {
+  addGetters(JSI_EXPORT_PROPERTY_GETTER(DelayNodeHostObject, delayTime));
+}
+
+size_t DelayNodeHostObject::getSizeInBytes() const {
+  auto delayNode = std::static_pointer_cast<DelayNode>(node_);
+  return sizeof(float) * delayNode->context_->getSampleRate() *
+      delayNode->getDelayTimeParam()->getMaxValue();
+}
+
+JSI_PROPERTY_GETTER_IMPL(DelayNodeHostObject, delayTime) {
+  auto delayNode = std::static_pointer_cast<DelayNode>(node_);
+  auto delayTimeParam = std::make_shared<AudioParamHostObject>(delayNode->getDelayTimeParam());
+  return jsi::Object::createFromHostObject(runtime, delayTimeParam);
+}
+
+} // namespace audioapi

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/DelayNodeHostObject.h

@@ -0,0 +1,21 @@
+#pragma once
+
+#include <audioapi/HostObjects/AudioNodeHostObject.h>
+
+#include <memory>
+#include <vector>
+
+namespace audioapi {
+using namespace facebook;
+
+class DelayNode;
+
+class DelayNodeHostObject : public AudioNodeHostObject {
+ public:
+  explicit DelayNodeHostObject(const std::shared_ptr<DelayNode> &node);
+
+  [[nodiscard]] size_t getSizeInBytes() const;
+
+  JSI_PROPERTY_GETTER_DECL(delayTime);
+};
+} // namespace audioapi

packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.cpp

@@ -70,6 +70,10 @@ bool AudioNode::isEnabled() const {
   return isEnabled_;
 }
 
+bool AudioNode::requiresTailProcessing() const {
+  return requiresTailProcessing_;
+}
+
 void AudioNode::enable() {
   if (isEnabled()) {
     return;

packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.h

@@ -38,13 +38,15 @@ class AudioNode : public std::enable_shared_from_this<AudioNode> {
       bool checkIsAlreadyProcessed);
 
   bool isEnabled() const;
+  bool requiresTailProcessing() const;
   void enable();
   virtual void disable();
 
  protected:
   friend class AudioNodeManager;
   friend class AudioDestinationNode;
   friend class ConvolverNode;
+  friend class DelayNodeHostObject;
 
   BaseAudioContext *context_;
   std::shared_ptr<AudioBus> audioBus_;
@@ -64,6 +66,7 @@ class AudioNode : public std::enable_shared_from_this<AudioNode> {
   int numberOfEnabledInputNodes_ = 0;
   bool isInitialized_ = false;
   bool isEnabled_ = true;
+  bool requiresTailProcessing_ = false;
 
   std::size_t lastRenderedFrame_{SIZE_MAX};
 

packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.cpp

@@ -3,6 +3,7 @@
 #include <audioapi/core/destinations/AudioDestinationNode.h>
 #include <audioapi/core/effects/BiquadFilterNode.h>
 #include <audioapi/core/effects/ConvolverNode.h>
+#include <audioapi/core/effects/DelayNode.h>
 #include <audioapi/core/effects/GainNode.h>
 #include <audioapi/core/effects/IIRFilterNode.h>
 #include <audioapi/core/effects/StereoPannerNode.h>
@@ -141,6 +142,12 @@ std::shared_ptr<GainNode> BaseAudioContext::createGain() {
   return gain;
 }
 
+std::shared_ptr<DelayNode> BaseAudioContext::createDelay(float maxDelayTime) {
+  auto delay = std::make_shared<DelayNode>(this, maxDelayTime);
+  nodeManager_->addProcessingNode(delay);
+  return delay;
+}
+
 std::shared_ptr<StereoPannerNode> BaseAudioContext::createStereoPanner() {
   auto stereoPanner = std::make_shared<StereoPannerNode>(this);
   nodeManager_->addProcessingNode(stereoPanner);