Skip to content

Conversation

@AJ-Waller
Copy link
Contributor

@AJ-Waller AJ-Waller commented Nov 7, 2025

This pull request makes the following changes:

  • Removes direct memory impacting Java-opts from dockerfiles

https://sonatype.atlassian.net/jira/software/c/projects/NEXUS/boards/48?selectedIssue=NEXUS-49546

@AJ-Waller AJ-Waller self-assigned this Nov 7, 2025
@AJ-Waller AJ-Waller requested a review from madpah as a code owner November 7, 2025 21:48
@AJ-Waller AJ-Waller changed the title NEXUS-46878: uppdated dockerfiles removing java opts [WIP] NEXUS-46878: uppdated dockerfiles removing java opts Nov 11, 2025
@AJ-Waller AJ-Waller requested a review from a team November 11, 2025 14:24
README.md Outdated

```
$ docker run -d -p 8081:8081 --name nexus -e INSTALL4J_ADD_VM_PARAMS="-Xms2703m -Xmx2703m -XX:MaxDirectMemorySize=2703m -Djava.util.prefs.userRoot=/some-other-dir" sonatype/nexus3
$ docker run -d -p 8081:8081 --name nexus -e INSTALL4J_ADD_VM_PARAMS="-Djava.util.prefs.userRoot=/some-other-dir" sonatype/nexus3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably still need this to show how to pass the values.

@tsawan
Copy link
Contributor

tsawan commented Nov 12, 2025

how are we now passing these settings to containers? I thought after removing the defaults we will need to update some scripts so the container can still function.

@AJ-Waller
Copy link
Contributor Author

how are we now passing these settings to containers? I thought after removing the defaults we will need to update some scripts so the container can still function.

@tsawan I was able to run these docker containers with nexus running without these defaults. But you could add them in by using the run command in the readme you commented on

This can be adjusted at runtime:

```
$ docker run -d -p 8081:8081 --name nexus -e INSTALL4J_ADD_VM_PARAMS="-Xms2703m -Xmx2703m -XX:MaxDirectMemorySize=2703m -Djava.util.prefs.userRoot=/some-other-dir" sonatype/nexus3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additional note about clarifying how to override JVM memory params won't hurt.

Copy link
Contributor

@nblair nblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a hold on this until internal validation has been completed.

@AJ-Waller AJ-Waller changed the title NEXUS-46878: uppdated dockerfiles removing java opts NEXUS-45946: updated dockerfiles removing java opts Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants