-
Notifications
You must be signed in to change notification settings - Fork 590
NEXUS-45946: updated dockerfiles removing java opts #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
README.md
Outdated
|
|
||
| ``` | ||
| $ docker run -d -p 8081:8081 --name nexus -e INSTALL4J_ADD_VM_PARAMS="-Xms2703m -Xmx2703m -XX:MaxDirectMemorySize=2703m -Djava.util.prefs.userRoot=/some-other-dir" sonatype/nexus3 | ||
| $ docker run -d -p 8081:8081 --name nexus -e INSTALL4J_ADD_VM_PARAMS="-Djava.util.prefs.userRoot=/some-other-dir" sonatype/nexus3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably still need this to show how to pass the values.
|
how are we now passing these settings to containers? I thought after removing the defaults we will need to update some scripts so the container can still function. |
@tsawan I was able to run these docker containers with nexus running without these defaults. But you could add them in by using the run command in the readme you commented on |
| This can be adjusted at runtime: | ||
|
|
||
| ``` | ||
| $ docker run -d -p 8081:8081 --name nexus -e INSTALL4J_ADD_VM_PARAMS="-Xms2703m -Xmx2703m -XX:MaxDirectMemorySize=2703m -Djava.util.prefs.userRoot=/some-other-dir" sonatype/nexus3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional note about clarifying how to override JVM memory params won't hurt.
nblair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a hold on this until internal validation has been completed.
This pull request makes the following changes:
https://sonatype.atlassian.net/jira/software/c/projects/NEXUS/boards/48?selectedIssue=NEXUS-49546