WIP

varungandhi-src · varungandhi-src · commit 2c6b27dcb8a3 · 2024-09-18T11:21:04.000-04:00
diff --git a/bindings/go/scip/symbol.go b/bindings/go/scip/symbol.go
@@ -642,6 +642,7 @@ func (z *zeroAllocSymbolParser) acceptIdentifier(what parseCtx) (string, error)
 		z.advanceRune()
 	}
 	if start == z.byteIndex {
+		fmt.Printf("z.currentRune = %q, z.byteIndex = %d, z.symbolString = %q\n", z.currentRune, z.byteIndex, z.SymbolString)
 		return "", z.error(errorCaseEmptyIdent, what)
 	}
 	return z.SymbolString[start:z.byteIndex], nil
diff --git a/bindings/go/scip/symbol_test.go b/bindings/go/scip/symbol_test.go
@@ -241,3 +241,13 @@ func TestParseV2(t *testing.T) {
 		}
 	})
 }
+
+func TestParseX(t *testing.T) {
+	s := "cxx . todo-pkg todo-version gfx/Rect#x(455f465bc33b4cdf)."
+	var sym Symbol
+	require.NotPanics(t, func() {
+		err := parsePartialSymbolV2(s, true, &sym)
+		require.NoError(t, err)
+		require.Len(t, sym.Descriptors, 3)
+	})
+}

Original file line number	Diff line number	Diff line change
`@@ -642,6 +642,7 @@ func (z *zeroAllocSymbolParser) acceptIdentifier(what parseCtx) (string, error)`
`642`	`642`	`z.advanceRune()`
`643`	`643`	`}`
`644`	`644`	`if start == z.byteIndex {`
	`645`	`+ fmt.Printf("z.currentRune = %q, z.byteIndex = %d, z.symbolString = %q\n", z.currentRune, z.byteIndex, z.SymbolString)`
`645`	`646`	`return "", z.error(errorCaseEmptyIdent, what)`
`646`	`647`	`}`
`647`	`648`	`return z.SymbolString[start:z.byteIndex], nil`
Original file line number	Diff line number	Diff line change
`@@ -241,3 +241,13 @@ func TestParseV2(t *testing.T) {`
`241`	`241`	`}`
`242`	`242`	`})`
`243`	`243`	`}`
	`244`	`+`
	`245`	`+func TestParseX(t *testing.T) {`
	`246`	`+ s := "cxx . todo-pkg todo-version gfx/Rect#x(455f465bc33b4cdf)."`
	`247`	`+ var sym Symbol`
	`248`	`+ require.NotPanics(t, func() {`
	`249`	`+ err := parsePartialSymbolV2(s, true, &sym)`
	`250`	`+ require.NoError(t, err)`
	`251`	`+ require.Len(t, sym.Descriptors, 3)`
	`252`	`+ })`
	`253`	`+}`