refactor: Implement case-insensitive comparison for permission name attribute in PermissionRegistrar

Author: imhayatunnabi

src/Models/Permission.php

@@ -49,17 +49,6 @@ public static function create(array $attributes = [])
             throw PermissionAlreadyExists::create($attributes['name'], $attributes['guard_name']);
         }
 
-        // Check for case-insensitive duplicate
-        $permissionClass = get_class(new static);
-        $existing = app($permissionClass)->where('guard_name', $attributes['guard_name'])->get()
-            ->filter(function ($item) use ($attributes) {
-                return strtolower($item->name) === strtolower($attributes['name']);
-            })->first();
-
-        if ($existing) {
-            throw PermissionAlreadyExists::create($attributes['name'], $attributes['guard_name']);
-        }
-
         return static::query()->create($attributes);
     }
 

src/Models/Role.php

@@ -62,26 +62,6 @@ public static function create(array $attributes = [])
             throw RoleAlreadyExists::create($attributes['name'], $attributes['guard_name']);
         }
 
-        // Check for case-insensitive duplicate
-        $roleClass = get_class(new static);
-        $query = app($roleClass)->where('guard_name', $attributes['guard_name']);
-
-        if ($registrar->teams) {
-            $teamsKey = $registrar->teamsKey;
-            $teamId = $params[$teamsKey] ?? getPermissionsTeamId();
-            $query = $query->where(function ($q) use ($teamsKey, $teamId) {
-                $q->whereNull($teamsKey)->orWhere($teamsKey, $teamId);
-            });
-        }
-
-        $existing = $query->get()->filter(function ($item) use ($attributes) {
-            return strtolower($item->name) === strtolower($attributes['name']);
-        })->first();
-
-        if ($existing) {
-            throw RoleAlreadyExists::create($attributes['name'], $attributes['guard_name']);
-        }
-
         return static::query()->create($attributes);
     }
 

src/PermissionRegistrar.php

@@ -246,7 +246,14 @@ public function getPermissions(array $params = [], bool $onlyOne = false): Colle
 
         $permissions = $this->permissions->$method(static function ($permission) use ($params) {
             foreach ($params as $attr => $value) {
-                if ($permission->getAttribute($attr) != $value) {
+                $permissionValue = $permission->getAttribute($attr);
+
+                // Case-insensitive comparison for 'name' attribute
+                if ($attr === 'name' && is_string($value) && is_string($permissionValue)) {
+                    if (strtolower($permissionValue) !== strtolower($value)) {
+                        return false;
+                    }
+                } elseif ($permissionValue != $value) {
                     return false;
                 }
             }