Skip to content

Commit 26bab76

Browse files
committed
Fix Google GenAI ITs
- Re-use import autoconfigs in the ITs Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
1 parent 86f013d commit 26bab76

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

auto-configurations/models/spring-ai-autoconfigure-model-google-genai/src/test/java/org/springframework/ai/model/google/genai/autoconfigure/chat/tool/FunctionCallWithFunctionWrapperIT.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,9 @@
2929
import org.springframework.ai.chat.prompt.Prompt;
3030
import org.springframework.ai.google.genai.GoogleGenAiChatModel;
3131
import org.springframework.ai.google.genai.GoogleGenAiChatOptions;
32-
import org.springframework.ai.model.google.genai.autoconfigure.chat.GoogleGenAiChatAutoConfiguration;
32+
import org.springframework.ai.model.google.genai.autoconfigure.BaseGoogleGenAiIT;
3333
import org.springframework.ai.tool.ToolCallback;
3434
import org.springframework.ai.tool.function.FunctionToolCallback;
35-
import org.springframework.boot.autoconfigure.AutoConfigurations;
36-
import org.springframework.boot.autoconfigure.web.client.RestClientAutoConfiguration;
3735
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3836

3937
import static org.assertj.core.api.Assertions.assertThat;
@@ -51,8 +49,7 @@ public class FunctionCallWithFunctionWrapperIT {
5149
void functionCallWithApiKey() {
5250
ApplicationContextRunner contextRunner = new ApplicationContextRunner()
5351
.withPropertyValues("spring.ai.google.genai.api-key=" + System.getenv("GOOGLE_API_KEY"))
54-
.withConfiguration(
55-
AutoConfigurations.of(RestClientAutoConfiguration.class, GoogleGenAiChatAutoConfiguration.class));
52+
.withConfiguration(BaseGoogleGenAiIT.googleGenAiChatAutoConfig());
5653

5754
contextRunner.run(context -> {
5855

@@ -89,8 +86,7 @@ void functionCallWithVertexAi() {
8986
ApplicationContextRunner contextRunner = new ApplicationContextRunner()
9087
.withPropertyValues("spring.ai.google.genai.project-id=" + System.getenv("GOOGLE_CLOUD_PROJECT"),
9188
"spring.ai.google.genai.location=" + System.getenv("GOOGLE_CLOUD_LOCATION"))
92-
.withConfiguration(
93-
AutoConfigurations.of(RestClientAutoConfiguration.class, GoogleGenAiChatAutoConfiguration.class));
89+
.withConfiguration(BaseGoogleGenAiIT.googleGenAiChatAutoConfig());
9490

9591
contextRunner.run(context -> {
9692

auto-configurations/models/spring-ai-autoconfigure-model-google-genai/src/test/java/org/springframework/ai/model/google/genai/autoconfigure/chat/tool/FunctionCallWithPromptFunctionIT.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,8 @@
2828
import org.springframework.ai.chat.prompt.Prompt;
2929
import org.springframework.ai.google.genai.GoogleGenAiChatModel;
3030
import org.springframework.ai.google.genai.GoogleGenAiChatOptions;
31-
import org.springframework.ai.model.google.genai.autoconfigure.chat.GoogleGenAiChatAutoConfiguration;
31+
import org.springframework.ai.model.google.genai.autoconfigure.BaseGoogleGenAiIT;
3232
import org.springframework.ai.tool.function.FunctionToolCallback;
33-
import org.springframework.boot.autoconfigure.AutoConfigurations;
3433
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
3534

3635
import static org.assertj.core.api.Assertions.assertThat;
@@ -48,7 +47,7 @@ public class FunctionCallWithPromptFunctionIT {
4847
void functionCallTestWithApiKey() {
4948
ApplicationContextRunner contextRunner = new ApplicationContextRunner()
5049
.withPropertyValues("spring.ai.google.genai.api-key=" + System.getenv("GOOGLE_API_KEY"))
51-
.withConfiguration(AutoConfigurations.of(GoogleGenAiChatAutoConfiguration.class));
50+
.withConfiguration(BaseGoogleGenAiIT.googleGenAiChatAutoConfig());
5251

5352
contextRunner
5453
.withPropertyValues("spring.ai.google.genai.chat.options.model="
@@ -93,7 +92,7 @@ void functionCallTestWithVertexAi() {
9392
ApplicationContextRunner contextRunner = new ApplicationContextRunner()
9493
.withPropertyValues("spring.ai.google.genai.project-id=" + System.getenv("GOOGLE_CLOUD_PROJECT"),
9594
"spring.ai.google.genai.location=" + System.getenv("GOOGLE_CLOUD_LOCATION"))
96-
.withConfiguration(AutoConfigurations.of(GoogleGenAiChatAutoConfiguration.class));
95+
.withConfiguration(BaseGoogleGenAiIT.googleGenAiChatAutoConfig());
9796

9897
contextRunner
9998
.withPropertyValues("spring.ai.google.genai.chat.options.model="

auto-configurations/models/spring-ai-autoconfigure-model-google-genai/src/test/java/org/springframework/ai/model/google/genai/autoconfigure/embedding/GoogleGenAiTextEmbeddingAutoConfigurationIT.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ void embeddingWithVertexAi() {
6464
ApplicationContextRunner contextRunner = new ApplicationContextRunner()
6565
.withPropertyValues("spring.ai.google.genai.embedding.project-id=" + System.getenv("GOOGLE_CLOUD_PROJECT"),
6666
"spring.ai.google.genai.embedding.location=" + System.getenv("GOOGLE_CLOUD_LOCATION"))
67-
.withConfiguration(AutoConfigurations.of(GoogleGenAiTextEmbeddingAutoConfiguration.class,
68-
GoogleGenAiEmbeddingConnectionAutoConfiguration.class));
67+
.withConfiguration(BaseGoogleGenAiIT.googleGenAiEmbeddingAutoConfig());
6968

7069
contextRunner.run(context -> {
7170
GoogleGenAiTextEmbeddingModel embeddingModel = context.getBean(GoogleGenAiTextEmbeddingModel.class);
@@ -96,9 +95,7 @@ void embeddingModelActivation() {
9695
});
9796

9897
// Test that embedding model is activated when enabled
99-
contextRunner
100-
.withConfiguration(AutoConfigurations.of(GoogleGenAiTextEmbeddingAutoConfiguration.class,
101-
GoogleGenAiEmbeddingConnectionAutoConfiguration.class))
98+
contextRunner.withConfiguration(BaseGoogleGenAiIT.googleGenAiEmbeddingAutoConfig())
10299
.withPropertyValues("spring.ai.model.embedding.text=google-genai")
103100
.run(context -> {
104101
assertThat(context.getBeansOfType(GoogleGenAiTextEmbeddingProperties.class)).isNotEmpty();

0 commit comments

Comments
 (0)