Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
…iers.ATTR_OPERATION Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
emilienbev
force-pushed
the
UpgradeSDK3.11
branch
from
84caa5b to
afe8d4d
Compare
onobc
reviewed
Feb 6, 2026
| CoreTransactionAttemptContext internal = ctxOpt.get().getCore(); | ||
| RequestSpan span = CbTracing.newSpan(internal.core().context(), TRANSACTION_OP_INSERT, | ||
| internal.span()); | ||
| span.attribute(TracingIdentifiers.ATTR_OPERATION, TRANSACTION_OP_INSERT); |
There was a problem hiding this comment.
Just curious, I see the ATTR_OPERATION span attributes have been removed but I don't see any reasoning in the release notes.
onobc
approved these changes
Feb 6, 2026
| CoreTransactionAttemptContext internal = ctxOpt.get().getCore(); | ||
| RequestSpan span = CbTracing.newSpan(internal.core().context(), TRANSACTION_OP_INSERT, | ||
| internal.span()); | ||
| span.attribute(TracingIdentifiers.ATTR_OPERATION, TRANSACTION_OP_INSERT); |
onobc
approved these changes
Feb 6, 2026
onobc
left a comment
onobc
left a comment
There was a problem hiding this comment.
Oh, one post-review comment @emilienbev...
Do you mind adding yourself as @ author on the modified files?
Signed-off-by: Emilien Bevierre <emilien.bevierre@couchbase.com>
emilienbev
force-pushed
the
UpgradeSDK3.11
branch
from
dcc5fd7 to
dde0290
Compare
Collaborator
Author
|
Thanks @onobc ! |
emilienbev
added
type: dependency-upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated and redundant
TracingIdentifiers.ATTR_OPERATION.