Add private constructor and null validation to CollectionUtils. #4108
+21
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve
CollectionUtilsutility class with defensive programming practices.Changes
1. Add private constructor
2. Add null validation with
Assert.notNull()@param list must not be null)NullPointerException3. Add unit tests for null validation
getFirstShouldRejectNullList()getLastShouldRejectNullList()Why these changes?
IllegalArgumentException