UserInfoFetcher: ActiveDirectory backend #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I saw this in the decision RfC column, anything particular you are looking for comments on? |
Contributor
Author
|
Primarily the CRD changes configuring the new backend. |
Contributor
Author
|
Moving CRD review to voting, please vote on this comment. |
sbernauer
reviewed
Aug 21, 2024
Co-authored-by: Sebastian Bernauer <[email protected]>
Contributor
Author
|
Closing CRD vote as accepted |
Contributor
Author
|
Proper testing is blocked on stackabletech/issues#629 |
1 task
soenkeliebau
previously approved these changes
Oct 25, 2024
Member
soenkeliebau
left a comment
soenkeliebau
left a comment
There was a problem hiding this comment.
Looked over the code and tested it - works as intended!
So, lgtm in principle, I just left a few questions throughout the code, none of them showstoppers though.
3 tasks
soenkeliebau
previously approved these changes
Oct 25, 2024
soenkeliebau
approved these changes
Oct 28, 2024
NickLarsenNZ
added a commit
to stackabletech/operator-templating
that referenced
this pull request
Oct 29, 2024
Otherwise it gets removed, like stackabletech/opa-operator#641
github-merge-queue bot
pushed a commit
to stackabletech/operator-templating
that referenced
this pull request
Oct 29, 2024
* chore(playbook): include more steps in the local test run * chore(playbook): auto recreate the work directory * fix(playbook): remove retired files * fix(template): Pull in a change from stackabletech/opa-operator#622 Otherwise it gets removed, like stackabletech/opa-operator#641 * refactor(template): Move local block into previous local block * chore(template): Revert nix formatting Also, see https://github.com/NixOS/nixfmt * fix(playbook): git config for dry-run Instead of using git config --global, make the git config commands local to each operator repository. This is then safe to run via test.sh (dry-run). * ci(generate_prs): Add dynamic run-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #524
Definition of Done Checklist