Skip to content

get sidebar to use all available vertical space #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
+9 −5
Draft

get sidebar to use all available vertical space #6179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22fa8a2
first attempt to get sidebar to use all vertical space
spaceyuck Oct 22, 2025
311430e
sidebar dynamic height works for saved filters too
spaceyuck Oct 26, 2025
ac49346
Revert "sidebar dynamic height works for saved filters too"
spaceyuck Oct 30, 2025
83a5af2
Revert "first attempt to get sidebar to use all vertical space"
spaceyuck Oct 30, 2025
91ec37b
Remove max-height and sticky sidebar section headers
WithoutPants Oct 30, 2025
b9fe590
sidebar move selected / excluded filter options into collapse header …
spaceyuck Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ui/v2.5/src/components/List/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@ input[type="range"].zoom-slider {
}
}

.sidebar-saved-filter-list-container .saved-filter-list {
max-height: unset;
}

.sidebar-saved-filter-list-container .toolbar {
align-items: center;
display: flex;
Expand Down Expand Up @@ -611,8 +615,6 @@ input[type="range"].zoom-slider {
.sidebar-list-filter ul {
list-style-type: none;
margin-bottom: 0.25rem;
max-height: 300px;
overflow-y: auto;
// to prevent unnecessary vertical scrollbar
padding-bottom: 0.15rem;
padding-inline-start: 0;
Expand Down
2 changes: 1 addition & 1 deletion ui/v2.5/src/components/Shared/CollapseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export const CollapseButton: React.FC<React.PropsWithChildren<IProps>> = (
<Icon icon={open ? faChevronDown : faChevronRight} fixedWidth />
<span>{props.text}</span>
</Button>
{props.outsideCollapse}
</div>
{props.outsideCollapse}
<Collapse in={open} {...props.collapseProps}>
<div>{props.children}</div>
</Collapse>
Expand Down
6 changes: 4 additions & 2 deletions ui/v2.5/src/components/Shared/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,9 +859,11 @@ button.btn.favorite-button {
border-bottom: 1px solid $secondary;

.collapse-header {
// background-color: $secondary;

background-color: $body-bg;
padding: 0.25rem;
position: sticky;
top: -0.5rem;
z-index: 1;

.collapse-button {
font-weight: bold;
Expand Down