Add vres and hres attributes to drawshape!()

Author: wsshin

src/util/plotting.jl

@@ -1,16 +1,17 @@
 const ϵrel = Base.rtoldefault(Float64)  # machine epsilon
-const N_PLOT_SAMPLING_POINTS = 101
 
 # Define drawshape() and drawshape!() functions.
 @recipe(DrawShape) do scene
-    Attributes()
-    Theme()
+    Attributes(vres=100, hres=100)
 end
 
 # Implement drawshape!() for 2D shapes.
 function Makie.plot!(ds::DrawShape{<:Tuple{Shape{2}}})
     shp = ds[1]
-    contour!(ds, shp, levels=SVector(0.0); ds.attributes...)  # Makie.convert_arguments() below handles this new signature
+    res = (ds.vres.val, ds.hres.val)  # found by examining typeof(ds) and fieldnames(typeof(ds)), etc
+
+    # Makie.convert_arguments() defined below handles this new signature.
+    contour!(ds, shp, res, levels=SVector(0.0); ds.attributes...)
 
     return ds
 end
@@ -19,18 +20,21 @@ end
 function Makie.plot!(ds::DrawShape{<:Tuple{Shape{3},Tuple{Symbol,Real}}})
     shp = ds[1]
     cs = ds[2]
-    contour!(ds, shp, cs, levels=SVector(0.0); ds.attributes...)  # Makie.convert_arguments() below handles this new signature
+    res = (ds.vres.val, ds.hres.val)  # found by examining typeof(ds) and fieldnames(typeof(ds)), etc
+
+    # Makie.convert_arguments() defined below handles this new signature.
+    contour!(ds, shp, cs, res, levels=SVector(0.0); ds.attributes...)
 
     return ds
 end
 
 # Define the new signature of contour!() used in drawshape!() for 2D shapes.
-function Makie.convert_arguments(P::SurfaceLike, shp::Shape{2})
+function Makie.convert_arguments(P::SurfaceLike, shp::Shape{2}, res::Tuple{Integer,Integer})
     lower, upper = bounds(shp)
     ∆ = upper - lower
 
-    nw = 1; xs = range(lower[nw] - ϵrel*∆[nw], upper[nw] + ϵrel*∆[nw], length=N_PLOT_SAMPLING_POINTS)
-    nw = 2; ys = range(lower[nw] - ϵrel*∆[nw], upper[nw] + ϵrel*∆[nw], length=N_PLOT_SAMPLING_POINTS)
+    nw = 1; xs = range(lower[nw] - ϵrel*∆[nw], upper[nw] + ϵrel*∆[nw], length=res[nw]+1)
+    nw = 2; ys = range(lower[nw] - ϵrel*∆[nw], upper[nw] + ϵrel*∆[nw], length=res[nw]+2)
 
     lvs = [level(@SVector([x,y]), shp) for x = xs, y = ys]
 
@@ -39,7 +43,8 @@ end
 
 # Define the new signature of contour!() used in drawshape!() for 3D shapes.
 function Makie.convert_arguments(P::SurfaceLike, shp::Shape{3},
-                                 cs::Tuple{Symbol,Real})  # (:x or :y or :z, intercept): cross section spec
+                                 cs::Tuple{Symbol,Real},  # (:x or :y or :z, intercept): cross section spec
+                                 res::Tuple{Integer,Integer})
     ax, cept = cs  # axis normal to cross section, intercept
 
     ax==:x || ax==:y || ax==:z || @error "cs[1] = $(cs[1]) should be :x or :y or :z."
@@ -54,8 +59,8 @@ function Makie.convert_arguments(P::SurfaceLike, shp::Shape{3},
     lower, upper = bounds(shp)
     ∆ = upper - lower
 
-    us = range(lower[nu] - ϵrel*∆[nu], upper[nu] + ϵrel*∆[nu], length=N_PLOT_SAMPLING_POINTS)
-    vs = range(lower[nv] - ϵrel*∆[nv], upper[nv] + ϵrel*∆[nv], length=N_PLOT_SAMPLING_POINTS)
+    us = range(lower[nu] - ϵrel*∆[nu], upper[nu] + ϵrel*∆[nu], length=res[1]+1)
+    vs = range(lower[nv] - ϵrel*∆[nv], upper[nv] + ϵrel*∆[nv], length=res[2]+1)
 
     lvs = [level(u*û + v*v̂ + cept*ŵ, shp) for u = us, v = vs]