fix(check): new counts were adding non task list items, added test to make sure this doesnt happen again

Author: stilliard

index.js

@@ -75,7 +75,6 @@ module.exports = (app) => {
     };
 
     // all finished?
-    console.log(outstandingTasks);
     if (outstandingTasks.remaining === 0) {
       check.status = 'completed';
       check.conclusion = 'success';

src/check-outstanding-tasks.js

@@ -13,7 +13,7 @@ module.exports = function (body) {
 
     // return counts of task list items and how many are left to be completed
     return {
-        total: listItems.length,
+        total: listItems.filter(item => item.checked !== undefined).length,
         remaining: listItems.filter(item => item.checked === false).length
     };
 };

tests/index.test.js

@@ -12,6 +12,7 @@ Hello World
     expect(results.total).toBe(2);
     expect(results.remaining).toBe(1);
 });
+
 test('Test no outstanding tasks', () => {
     let markdown = `
 Hello World
@@ -22,3 +23,24 @@ Hello World
     expect(results.total).toBe(2);
     expect(results.remaining).toBe(0);
 });
+
+test('Test no tasks', () => {
+    let markdown = `
+Hello World
+`;
+    let results = checkOutstandingTasks(markdown);
+    expect(results.total).toBe(0);
+    expect(results.remaining).toBe(0);
+});
+
+test('Test dont count normal lists', () => {
+    let markdown = `
+Hello World
+- normal
+- [x] task 1
+- [ ] task 2
+`;
+    let results = checkOutstandingTasks(markdown);
+    expect(results.total).toBe(2);
+    expect(results.remaining).toBe(1);
+});